From: Rajeev Mishra <rajeevm@hpe.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Rajeev Mishra <rajeevm@hpe.com>
Subject: [PATCH 1/1] loop: sync filesystem cache before getting file size in get_size()
Date: Thu, 7 Aug 2025 23:25:22 +0000 [thread overview]
Message-ID: <20250807232522.192898-1-rajeevm@hpe.com> (raw)
The get_size() function now uses vfs_getattr_nosec() with AT_STATX_SYNC_AS_STAT
to ensure filesystem cache is synchronized before retrieving file size. This
provides more accurate size information, especially when:
- The backing file size has been changed by another process
- The file is on a network filesystem (NFS, CIFS, etc.)
- The file is being modified concurrently
- The most accurate size is needed for loop device setup
The implementation gracefully falls back to i_size_read() if vfs_getattr_nosec()
fails, maintaining backward compatibility.
Signed-off-by: Rajeev Mishra <rajeevm@hpe.com>
---
drivers/block/loop.c | 31 +++++++++++++++++++++++++++++--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1b6ee91f8eb9..15d5edbc69ce 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -137,12 +137,39 @@ static void loop_global_unlock(struct loop_device *lo, bool global)
static int max_part;
static int part_shift;
+/**
+ * get_size - calculate the effective size of a loop device
+ * @offset: offset into the backing file
+ * @sizelimit: user-specified size limit
+ * @file: the backing file
+ *
+ * Calculate the effective size of the loop device
+ *
+ * Returns: size in 512-byte sectors, or 0 if invalid
+ */
static loff_t get_size(loff_t offset, loff_t sizelimit, struct file *file)
{
+ struct kstat stat;
loff_t loopsize;
+ int ret;
+
+ /*
+ * Get file attributes for validation. We use vfs_getattr() to ensure
+ * we have up-to-date file size information.
+ */
+ ret = vfs_getattr_nosec(&file->f_path, &stat, STATX_SIZE,
+ AT_STATX_SYNC_AS_STAT);
+ if (ret) {
+ /*
+ * If we can't get attributes, fall back to i_size_read()
+ * which should work for most cases.
+ */
+ loopsize = i_size_read(file->f_mapping->host);
+ } else {
+ /* Use the size from getattr for consistency */
+ loopsize = stat.size;
+ }
- /* Compute loopsize in bytes */
- loopsize = i_size_read(file->f_mapping->host);
if (offset > 0)
loopsize -= offset;
/* offset is beyond i_size, weird but possible */
--
2.43.5
next reply other threads:[~2025-08-07 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 23:25 Rajeev Mishra [this message]
2025-08-08 2:47 ` Yu Kuai
[not found] ` <PH7PR84MB2079A6A4EFE799BCA7E5738CAA2FA@PH7PR84MB2079.NAMPRD84.PROD.OUTLOOK.COM>
2025-08-11 1:20 ` Yu Kuai
2025-08-10 15:15 ` Christoph Hellwig
2025-08-15 3:25 ` kernel test robot
2025-08-08 18:59 Cloud User
2025-08-08 19:03 Cloud User
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807232522.192898-1-rajeevm@hpe.com \
--to=rajeevm@hpe.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®