From: Frank Li <Frank.Li@nxp.com>
To: Rui Miguel Silva <rmfrfs@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Eugen Hristev <eugen.hristev@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Alice Yuan <alice.yuan@nxp.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-staging@lists.linux.dev,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v2 06/32] media: staging: media: imx6-mipi-csi2: use devm_add_action_or_reset() to simplify code
Date: Fri, 08 Aug 2025 18:39:09 -0400 [thread overview]
Message-ID: <20250808-95_cam-v2-6-4b29fa6919a7@nxp.com> (raw)
In-Reply-To: <20250808-95_cam-v2-0-4b29fa6919a7@nxp.com>
Use devm_add_action_or_reset() to simplify the code. No functional change.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/staging/media/imx/imx6-mipi-csi2.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/imx/imx6-mipi-csi2.c b/drivers/staging/media/imx/imx6-mipi-csi2.c
index 42256441b881d9f132ad7ff899d6f1e35643b4ac..eba9a650030f5e380aa900b94728ad375171c6a5 100644
--- a/drivers/staging/media/imx/imx6-mipi-csi2.c
+++ b/drivers/staging/media/imx/imx6-mipi-csi2.c
@@ -716,6 +716,14 @@ static int csi2_async_register(struct csi2_dev *csi2)
return ret;
}
+static void csi2_nf_cleanup(void *data)
+{
+ struct csi2_dev *csi2 = data;
+
+ v4l2_async_nf_unregister(&csi2->notifier);
+ v4l2_async_nf_cleanup(&csi2->notifier);
+}
+
static int csi2_probe(struct platform_device *pdev)
{
struct csi2_dev *csi2;
@@ -749,6 +757,10 @@ static int csi2_probe(struct platform_device *pdev)
if (ret)
return ret;
+ ret = devm_add_action_or_reset(&pdev->dev, csi2_nf_cleanup, csi2);
+ if (ret)
+ return ret;
+
csi2->pllref_clk = devm_clk_get(&pdev->dev, "ref");
if (IS_ERR(csi2->pllref_clk)) {
v4l2_err(&csi2->sd, "failed to get pll reference clock\n");
@@ -800,8 +812,6 @@ static int csi2_probe(struct platform_device *pdev)
return 0;
clean_notifier:
- v4l2_async_nf_unregister(&csi2->notifier);
- v4l2_async_nf_cleanup(&csi2->notifier);
clk_disable_unprepare(csi2->dphy_clk);
pllref_off:
clk_disable_unprepare(csi2->pllref_clk);
@@ -815,8 +825,6 @@ static void csi2_remove(struct platform_device *pdev)
struct v4l2_subdev *sd = platform_get_drvdata(pdev);
struct csi2_dev *csi2 = sd_to_dev(sd);
- v4l2_async_nf_unregister(&csi2->notifier);
- v4l2_async_nf_cleanup(&csi2->notifier);
v4l2_async_unregister_subdev(sd);
clk_disable_unprepare(csi2->dphy_clk);
clk_disable_unprepare(csi2->pllref_clk);
--
2.34.1
next prev parent reply other threads:[~2025-08-08 22:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 22:39 [PATCH v2 00/32] media: add imx93 mipi/controller csi support Frank Li
2025-08-08 22:39 ` [PATCH v2 01/32] dt-bindings: media: add DW MIPI CSI-2 Host support Frank Li
2025-08-18 14:39 ` Rob Herring
2025-08-08 22:39 ` [PATCH v2 02/32] media: v4l2-common: Add helper function v4l_get_required_align_by_bpp() Frank Li
2025-08-08 22:39 ` [PATCH v2 03/32] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_bpp() Frank Li
2025-08-08 22:39 ` [PATCH v2 04/32] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_dt() Frank Li
2025-08-20 19:16 ` Laurent Pinchart
2025-08-08 22:39 ` [PATCH v2 05/32] media: staging: media: imx6-mipi-csi2: replace space with tab for alignment Frank Li
2025-08-08 22:39 ` Frank Li [this message]
2025-08-08 22:39 ` [PATCH v2 07/32] media: staging: media: imx6-mipi-csi2: use devm_clk_bulk_get_all() to fetch clocks Frank Li
2025-08-08 22:39 ` [PATCH v2 08/32] media: staging: media: imx6-mipi-csi2: use devm_mutex_init() to simplify code Frank Li
2025-08-08 22:39 ` [PATCH v2 09/32] media: staging: media: imx6-mipi-csi2: use guard() " Frank Li
2025-08-08 22:39 ` [PATCH v2 10/32] media: staging: media: imx6-mipi-csi2: use register structure to match hardware Frank Li
2025-08-08 22:39 ` [PATCH v2 11/32] media: staging: media: imx6-mipi-csi2: use devm_platform_ioremap_resource() simplify code Frank Li
2025-08-08 22:39 ` [PATCH v2 12/32] media: staging: media: imx6-mipi-csi2: move probe part to imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 13/32] media: staging: media: imx6-mipi-csi2: move sd imx6's specific initialization into imx6-sci2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 14/32] media: staging: media: imx6-mipi-csi2: move csi2ipu_gasket_init() to imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 15/32] media: staging: media: imx6-mipi-csi2: move number pad macro define into imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 16/32] media: staging: media: imx6-mipi-csi2: move dphy init part to imx6-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 17/32] media: staging: media: imx6-mipi-csi2: use runtime_pm frame to control clks Frank Li
2025-08-08 22:39 ` [PATCH v2 18/32] media: synopsys: move imx6-mipi-csi2.c to synopsys/mipi-csi2.c Frank Li
2025-08-08 22:39 ` [PATCH v2 19/32] media: synopsys: csi2: Remove deprecated s_stream and use v4l2_subdev_pad_ops Frank Li
2025-08-08 22:39 ` [PATCH v2 20/32] media: synopsys: csi2: Add phy interface support Frank Li
2025-08-08 22:39 ` [PATCH v2 21/32] media: synopsys: csi2: Add basic v150* version register Frank Li
2025-08-08 22:39 ` [PATCH v2 22/32] media: synopsys: csi2: Add irq support to record error count Frank Li
2025-08-08 22:39 ` [PATCH v2 23/32] media: synopsys: csi2: Handle alignment requirement for width Frank Li
2025-08-08 22:39 ` [PATCH v2 24/32] media: synopsys: csi2: Add register prefix to register field definitions Frank Li
2025-08-08 22:39 ` [PATCH v2 25/32] media: synopsys: csi2: Add need_dphy_reset in config Frank Li
2025-08-08 22:39 ` [PATCH v2 26/32] media: synopsys: csi2: Add default simple dw_csi2_subdev_init_state Frank Li
2025-08-08 22:39 ` [PATCH v2 27/32] media: synopsys: csi2: Add v150 lane stop state register bit define Frank Li
2025-08-08 22:39 ` [PATCH v2 28/32] media: synopsys: csi2: use standard v4l2_subdev_get_fmt() function Frank Li
2025-08-08 22:39 ` [PATCH v2 29/32] media: synopsys: csi2: Add customize get_frame_desc() callback Frank Li
2025-08-08 22:39 ` [PATCH v2 30/32] media: synopsys: csi2: Add Image Pixel Interface (IPI) support for v150 Frank Li
2025-08-08 22:39 ` [PATCH v2 31/32] media: synopsys: csi2: Remove source pad connected check at dw_csi2_enable_streams() Frank Li
2025-08-08 22:39 ` [PATCH v2 32/32] media: synopsys: csi2: Add simple synopsys platform driver Frank Li
2025-08-20 14:39 ` [PATCH v2 00/32] media: add imx93 mipi/controller csi support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808-95_cam-v2-6-4b29fa6919a7@nxp.com \
--to=frank.li@nxp.com \
--cc=alice.yuan@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@linaro.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®