From: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Dmitry Baryshkov <lumag@kernel.org>, Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jessica Zhang <jessica.zhang@oss.qualcomm.com>,
Kuogee Hsieh <quic_khsieh@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Yongxing Mou <quic_yongmou@quicinc.com>
Subject: [PATCH v2 12/12] drm/msm/dp: Add sink_count and link_ready to debug logs
Date: Fri, 08 Aug 2025 17:35:24 -0700 [thread overview]
Message-ID: <20250808-hpd-refactor-v2-12-7f4e1e741aa3@oss.qualcomm.com> (raw)
In-Reply-To: <20250808-hpd-refactor-v2-0-7f4e1e741aa3@oss.qualcomm.com>
Add sink count and link_ready to the debug logs for [un]plug and HPD IRQ
handling.
Signed-off-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 38 ++++++++++++++++++++++++-------------
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index dd529942f7db..93ea623473f4 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -455,8 +455,10 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 data)
msm_dp_aux_enable_xfers(dp->aux, true);
- drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "Before, type=%d sink_count=%d, link_ready=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count,
+ dp->msm_dp_display.link_ready);
if (dp->msm_dp_display.link_ready)
return 0;
@@ -473,8 +475,10 @@ static int msm_dp_hpd_plug_handle(struct msm_dp_display_private *dp, u32 data)
pm_runtime_put_sync(&pdev->dev);
}
- drm_dbg_dp(dp->drm_dev, "After, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "After, type=%d sink_count=%d, link_ready=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count,
+ dp->msm_dp_display.link_ready);
/* uevent will complete connection part */
return 0;
@@ -500,8 +504,10 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data)
msm_dp_aux_enable_xfers(dp->aux, false);
- drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "Before, type=%d sink_count=%d, link_ready=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count,
+ dp->msm_dp_display.link_ready);
if (!dp->msm_dp_display.link_ready)
return 0;
@@ -528,8 +534,10 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data)
/* signal the disconnect event early to ensure proper teardown */
msm_dp_display_handle_plugged_change(&dp->msm_dp_display, false);
- drm_dbg_dp(dp->drm_dev, "After, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "After, type=%d, sink_count=%d, link_ready=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count,
+ dp->msm_dp_display.link_ready);
/* uevent will complete disconnection part */
pm_runtime_put_sync(&pdev->dev);
@@ -539,13 +547,17 @@ static int msm_dp_hpd_unplug_handle(struct msm_dp_display_private *dp, u32 data)
static int msm_dp_irq_hpd_handle(struct msm_dp_display_private *dp, u32 data)
{
/* irq_hpd can happen at either connected or disconnected state */
- drm_dbg_dp(dp->drm_dev, "Before, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "Before, type=%d, sink_count=%d, link_ready=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count,
+ dp->msm_dp_display.link_ready);
msm_dp_display_usbpd_attention_cb(&dp->msm_dp_display.pdev->dev);
- drm_dbg_dp(dp->drm_dev, "After, type=%d\n",
- dp->msm_dp_display.connector_type);
+ drm_dbg_dp(dp->drm_dev, "After, type=%d, sink_count=%d, link_ready=%d\n",
+ dp->msm_dp_display.connector_type,
+ dp->link->sink_count,
+ dp->msm_dp_display.link_ready);
return 0;
}
@@ -1540,7 +1552,7 @@ void msm_dp_bridge_hpd_notify(struct drm_bridge *bridge,
hpd_link_status = msm_dp_aux_is_link_connected(dp->aux);
}
- drm_dbg_dp(dp->drm_dev, "type=%d link connected=0x%x, link_ready=%d, status=%d\n",
+ drm_dbg_dp(dp->drm_dev, "type=%d link hpd_link_status=0x%x, link_ready=%d, status=%d\n",
msm_dp_display->connector_type, hpd_link_status,
msm_dp_display->link_ready, status);
--
2.50.1
prev parent reply other threads:[~2025-08-09 0:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 0:35 [PATCH v2 00/12] drm/msm/dp: Drop the HPD state machine Jessica Zhang
2025-08-09 0:35 ` [PATCH v2 01/12] drm/msm/dp: fix HPD state status bit shift value Jessica Zhang
2025-08-09 0:38 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 02/12] drm/msm/dp: Fix the ISR_* enum values Jessica Zhang
2025-08-09 0:35 ` [PATCH v2 03/12] drm/msm/dp: Read DPCD and sink count in bridge detect() Jessica Zhang
2025-08-09 0:44 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 04/12] drm/msm/dp: Move link training to atomic_enable() Jessica Zhang
2025-08-09 0:45 ` Dmitry Baryshkov
2025-08-09 0:53 ` Jessica Zhang
2025-08-09 0:51 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 05/12] drm/msm/dp: Drop EV_USER_NOTIFICATION Jessica Zhang
2025-08-09 2:14 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 06/12] drm/msm/dp: Use drm_bridge_hpd_notify() Jessica Zhang
2025-08-09 6:46 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 07/12] drm/msm/dp: Handle internal HPD IRQ in hpd_notify() Jessica Zhang
2025-08-09 7:05 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 08/12] drm/msm/dp: Drop event waitqueue Jessica Zhang
2025-08-09 7:08 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 09/12] drm/msm/dp: remove redundant checks related to ST_DISPLAY_OFF in plug handler Jessica Zhang
2025-08-09 7:10 ` Dmitry Baryshkov
2025-08-09 0:35 ` [PATCH v2 10/12] drm/msm/dp: Return early from atomic_enable() if cable is not connected Jessica Zhang
2025-08-09 0:35 ` [PATCH v2 11/12] drm/msm/dp: drop the entire HPD state machine Jessica Zhang
2025-08-09 7:26 ` Dmitry Baryshkov
2025-08-09 0:35 ` Jessica Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808-hpd-refactor-v2-12-7f4e1e741aa3@oss.qualcomm.com \
--to=jessica.zhang@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_khsieh@quicinc.com \
--cc=quic_yongmou@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®