From: Ben Dooks <ben.dooks@codethink.co.uk>
To: robh@kernel.org, saravanak@google.com, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben.dooks@codethink.co.uk>
Subject: [RFC/PATCH] drivers/of: add debug for early dump of the dtb strcutrue
Date: Fri, 8 Aug 2025 15:25:15 +0100 [thread overview]
Message-ID: <20250808142515.142058-1-ben.dooks@codethink.co.uk> (raw)
When testing for boot issues, it was helpful to dump the
list of nodes and properties in the device-tree passed into
the kernel.
Add CONFIG_OF_EARLY_DUMP option to dump the list of nodes
and properties to the standard console output early in the
boot sequence. Note, you may need to have some sort of
early or debug console output if there are issues stopping
the kernel starting properly.
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
drivers/of/Kconfig | 8 ++++++++
drivers/of/fdt.c | 39 +++++++++++++++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
index 50697cc3b07e..ed2c52c54a7d 100644
--- a/drivers/of/Kconfig
+++ b/drivers/of/Kconfig
@@ -126,4 +126,12 @@ config OF_OVERLAY_KUNIT_TEST
config OF_NUMA
bool
+config OF_EARLY_DUMP
+ bool "Dump node list at startup"
+ help
+ This debug feature runs through all the nodes/properties at startup
+ to show if the dtb has been passed correctly from the boot stage.
+
+ If unsure, say N here
+
endif # OF
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index 0edd639898a6..ab40db0e71a5 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -1164,6 +1164,43 @@ static void * __init early_init_dt_alloc_memory_arch(u64 size, u64 align)
return memblock_alloc_or_panic(size, align);
}
+#ifdef CONFIG_OF_EARLY_DUMP
+static int __init early_init_iterate_nodes(unsigned long node,
+ const char *uname,
+ int depth, void *data)
+{
+ void *blob = initial_boot_params;
+ int cur;
+
+ pr_info("node '%s', depth %d\n", uname, depth);
+
+ for (cur = fdt_first_property_offset(blob, node);
+ cur >= 0;
+ cur = fdt_next_property_offset(blob, cur)) {
+ const char *pname;
+ const __be32 *val;
+ u32 sz;
+
+ val = fdt_getprop_by_offset(blob, cur, &pname, &sz);
+ if (!val) {
+ pr_warn("Cannot locate property at 0x%x\n", cur);
+ continue;
+ }
+
+ pr_info("node %s: property %s\n", uname, pname ? pname : "unnamed");
+ }
+
+ return 0;
+}
+
+static inline void early_init_dump_dt(void)
+{
+ of_scan_flat_dt(early_init_iterate_nodes, NULL);
+}
+#else
+static inline void early_init_dump_dt(void) { }
+#endif /* CONFIG_OF_EARLY_DUMP */
+
bool __init early_init_dt_verify(void *dt_virt, phys_addr_t dt_phys)
{
if (!dt_virt)
@@ -1178,6 +1215,8 @@ bool __init early_init_dt_verify(void *dt_virt, phys_addr_t dt_phys)
initial_boot_params_pa = dt_phys;
of_fdt_crc32 = crc32_be(~0, initial_boot_params,
fdt_totalsize(initial_boot_params));
+
+ early_init_dump_dt();
/* Initialize {size,address}-cells info */
early_init_dt_scan_root();
--
2.37.2.352.g3c44437643
next reply other threads:[~2025-08-08 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 14:25 Ben Dooks [this message]
2025-08-08 16:25 ` Rob Herring
2025-08-08 21:10 ` Saravana Kannan
2025-08-11 8:02 ` Ben Dooks
2025-08-18 14:17 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808142515.142058-1-ben.dooks@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®