From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev,
"Ioana Risteiu" <Ioana.Risteiu@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ramona Nechita" <ramona.nechita@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
Ioana Risteiu <Ioana.Risteiu@analog.com>
Subject: Re: [PATCH v2 3/3] iio: adc: update ad7779 to use IIO backend
Date: Mon, 11 Aug 2025 09:46:18 +0300 [thread overview]
Message-ID: <202508090909.tqDX7ah1-lkp@intel.com> (raw)
In-Reply-To: <20250806192502.10120-4-Ioana.Risteiu@analog.com>
Hi Ioana,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ioana-Risteiu/iio-adc-adi-axi-adc-add-axi_adc_num_lanes_set/20250807-032923
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link: https://lore.kernel.org/r/20250806192502.10120-4-Ioana.Risteiu%40analog.com
patch subject: [PATCH v2 3/3] iio: adc: update ad7779 to use IIO backend
config: x86_64-randconfig-161-20250809 (https://download.01.org/0day-ci/archive/20250809/202508090909.tqDX7ah1-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202508090909.tqDX7ah1-lkp@intel.com/
smatch warnings:
drivers/iio/adc/ad7779.c:893 setup_back() warn: passing zero to 'dev_err_probe'
vim +/dev_err_probe +893 drivers/iio/adc/ad7779.c
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 879 static int setup_back(struct ad7779_state *st, struct iio_dev *indio_dev)
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 880 {
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 881 struct device *dev = &st->spi->dev;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 882 int ret = -EINVAL;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 883 int num_lanes;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 884
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 885 indio_dev->info = &ad7779_info_data;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 886
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 887 ret = ad7779_conf_channels(indio_dev, st);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 888 if (ret)
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 889 return ret;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 890
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 891 st->back = devm_iio_backend_get(dev, NULL);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 892 if (IS_ERR(st->back)) {
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 @893 dev_err_probe(dev, ret, "failed to get iio backend");
s/ret/PTR_ERR(st->back)/
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 894 return PTR_ERR(st->back);
Change this to:
if (IS_ERR(st->back))
return dev_err_probe(dev, PTR_ERR(st->back),
"failed to get iio backend");
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 895 }
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 896
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 897 ret = devm_iio_backend_request_buffer(dev, st->back, indio_dev);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 898 if (ret)
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 899 return ret;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 900
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 901 ret = devm_iio_backend_enable(dev, st->back);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 902 if (ret)
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 903 return ret;
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 904
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 905 ret = device_property_read_u32(dev, "adi,num-lanes", &num_lanes);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 906 if (ret < 0)
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 907 return ad7779_set_data_lines(indio_dev, 4);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 908
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 909 return ad7779_set_data_lines(indio_dev, num_lanes);
1d61d2e4f96ac5 Ioana Risteiu 2025-08-06 910 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2025-08-11 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 19:24 [PATCH v2 0/3] Add IIO backend support for AD7779 Ioana Risteiu
2025-08-06 19:24 ` [PATCH v2 1/3] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set Ioana Risteiu
2025-08-06 19:24 ` [PATCH v2 2/3] dt-bindings: iio: adc: add IIO backend support Ioana Risteiu
2025-08-08 6:52 ` Krzysztof Kozlowski
2025-08-06 19:25 ` [PATCH v2 3/3] iio: adc: update ad7779 to use IIO backend Ioana Risteiu
2025-08-06 20:36 ` Andy Shevchenko
2025-08-09 19:37 ` Jonathan Cameron
2025-08-09 19:48 ` Jonathan Cameron
2025-08-11 6:46 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508090909.tqDX7ah1-lkp@intel.com \
--to=dan.carpenter@linaro.org \
--cc=Ioana.Risteiu@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®