From: Joel Fernandes <joelagnelf@nvidia.com>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>
Cc: Joel Fernandes <joelagnelf@nvidia.com>, Tejun Heo <tj@kernel.org>,
David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>
Subject: [PATCH -rebased 04/15] sched/deadline: Return EBUSY if dl_bw_cpus is zero
Date: Sat, 9 Aug 2025 14:47:49 -0400 [thread overview]
Message-ID: <20250809184800.129831-5-joelagnelf@nvidia.com> (raw)
In-Reply-To: <20250809184800.129831-1-joelagnelf@nvidia.com>
Hotplugged CPUs coming online do an enqueue but are not a part of any
root domain containing cpu_active() CPUs. So in this case, don't mess
with accounting and we can retry later. Without this patch, we see
crashes with sched_ext selftest's hotplug test due to divide by zero.
Signed-off-by: Joel Fernandes <joelagnelf@nvidia.com>
---
kernel/sched/deadline.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 3c478a1b2890..753e50b1e86f 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1689,7 +1689,12 @@ int dl_server_apply_params(struct sched_dl_entity *dl_se, u64 runtime, u64 perio
cpus = dl_bw_cpus(cpu);
cap = dl_bw_capacity(cpu);
- if (__dl_overflow(dl_b, cap, old_bw, new_bw))
+ /*
+ * Hotplugged CPUs coming online do an enqueue but are not a part of any
+ * root domain containing cpu_active() CPUs. So in this case, don't mess
+ * with accounting and we can retry later.
+ */
+ if (!cpus || __dl_overflow(dl_b, cap, old_bw, new_bw))
return -EBUSY;
if (init) {
--
2.34.1
next prev parent reply other threads:[~2025-08-09 18:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-09 18:47 [PATCH -rebased 00/15] Add a deadline server for sched_ext tasks Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 01/15] sched/debug: Fix updating of ppos on server write ops Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 02/15] sched/debug: Stop and start server based on if it was active Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 03/15] sched/deadline: Clear the defer params Joel Fernandes
2025-08-09 18:47 ` Joel Fernandes [this message]
2025-08-09 18:47 ` [PATCH -rebased 05/15] sched: Add support to pick functions to take rf Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 06/15] sched: Add a server arg to dl_server_update_idle_time() Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 07/15] sched_ext: Add a DL server for sched_ext tasks Joel Fernandes
2025-08-19 7:57 ` Peter Zijlstra
2025-08-20 15:52 ` Andrea Righi
2025-08-20 17:52 ` Joel Fernandes
2025-08-20 18:19 ` Andrea Righi
2025-08-09 18:47 ` [PATCH -rebased 08/15] sched/debug: Add support to change sched_ext server params Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 09/15] sched/deadline: Add support to remove DL server's bandwidth contribution Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 10/15] sched/deadline: Account ext server bandwidth Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 11/15] sched/deadline: Allow to initialize DL server when needed Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 12/15] sched_ext: Selectively enable ext and fair DL servers Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 13/15] sched/deadline: Fix DL server crash in inactive_timer callback Joel Fernandes
2025-08-09 18:47 ` [PATCH -rebased 14/15] selftests/sched_ext: Add test for sched_ext dl_server Joel Fernandes
2025-08-09 18:48 ` [PATCH -rebased 15/15] selftests/sched_ext: Add test for DL server total_bw consistency Joel Fernandes
2025-08-13 9:15 ` [PATCH -rebased 00/15] Add a deadline server for sched_ext tasks Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250809184800.129831-5-joelagnelf@nvidia.com \
--to=joelagnelf@nvidia.com \
--cc=arighi@nvidia.com \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®