From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A63527510E; Sat, 9 Aug 2025 20:00:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754769617; cv=none; b=QYSi5eaM3iTT6sMs3OIi1z+8390kvM0YPvqIgDd38DDqSwccyyUrN8AT9o+zMBtFRAKZRVq5Q5WBj2DHsvdyEDD1T/W+MWr9NcczFPaywsJ/SrkDMJtDdkx1Wi4GzFlF5AsAV1LAOObhzoGh+QxTofM9XeRd84arl6qfqPKcypk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754769617; c=relaxed/simple; bh=7fQBK8bgFE1Ri1Krh9HfuYIeNKOzqdzxblIbW7hnQXQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DFc1kRCZ6t5j16GlPfzu7/eSKWmygWQgB/jNxm26SJEhhYFfY2ba62go7oVkyAKRfdysO3BV9Db7tX3yn9hwk/IcEtP05222AAVw2E6ow3KfwHv8FAA1KTpVMfdecBQzlS1Cry7TWiqL1pL+CPQnufMGLNwSnvNjyelqWLcvykw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=GBfpFW+t; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="GBfpFW+t" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 432F4C4CEE7; Sat, 9 Aug 2025 20:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754769616; bh=7fQBK8bgFE1Ri1Krh9HfuYIeNKOzqdzxblIbW7hnQXQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GBfpFW+tldLQvKQQnUCTIxV092GzoC3t6M7VHOAiWjRrEBBkv7QIw0lX0maHUrfQn WNPg5HnhwTezF2HG9Mf+obGeahDBhbzh51uRWrEkfvCUUFVvLxrk/zJfyNCNtL8w2j k09TFBa8vO1yehyW9TuqvYzGAjNx11Jm+zO7PQwHzuvYdj8GO0yhgNyT0n3FV5d/NP vpizg1ixql0wV6LjMsH4jn/G5VZPROpKjsYg8vGgN8LQ0IRuwU3jpQdGkehyrAudvI ekPwDPD/0u+UcAH3gQLmajUXN5nA9OA0uIlzh2/Pcwmb9vYLXkz7OMppBtWWFkzn09 Ky7m/QSekg1sw== Date: Sat, 9 Aug 2025 21:00:01 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Waqar Hameed , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Matthias Brugger , AngeloGioacchino Del Regno , Matteo Martelli , Heiko Stuebner , Francesco Dolcini , =?UTF-8?B?Sm/Do28=?= Paulo =?UTF-8?B?R29uw6dhbHZlcw==?= , Hugo Villeneuve , Subhajit Ghosh , Mudit Sharma , Gerald Loacker , Song Qiang , Crt Mori , kernel@axis.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] iio: Remove error prints for devm_add_action_or_reset() Message-ID: <20250809210001.4d8af4cd@jic23-huawei> In-Reply-To: References: X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 5 Aug 2025 15:06:02 +0200 Andy Shevchenko wrote: > On Tue, Aug 5, 2025 at 11:33=E2=80=AFAM Waqar Hameed wrote: > > > > When `devm_add_action_or_reset()` fails, it is due to a failed memory > > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do > > anything when error is `-ENOMEM`. Therefore, remove the useless call to > > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just > > return the value instead. =20 >=20 > Even more, the devm has tracepoints in case somebody really wants to > investigate failures. >=20 > Fully in support of this change. > Reviewed-by: Andy Shevchenko >=20 Applied to the testing branch of iio.git. I'll rebase that on rc1 once available. Jonathan