From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8402F1E50E; Sun, 10 Aug 2025 12:58:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754830683; cv=none; b=nKiAl1J9fdWhpbt7SsbRzzRN38AILbEMKFledUjmiWs5M6En7sr2+eOc+hUkWzyF3tswtLNfjmeP9u1XOnTfp9kRF6o7Urx3U3wZ4X0ll9y4vajmHtaDI0pVtB+0DJNJiN+UYpim0AF9YfqzKi8OvwXdUlCKdNRKl74IfVjjZsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754830683; c=relaxed/simple; bh=EhLsZojnCpTP6DR0ZKTrGtcX/QnBRFrvIOrMtYcrMLQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=W4ZYZ+NKcNL+oHiXQ3oFA8U4Wwqm7OxlFyXVMkg7wjz1PBNyXjHC5x+KPpgtYvzowHv/ikE5BpUNIrrRyGMmNHxoyJUQFQkz1i6iu6cMfK21sQwTH4PpVRo3UndDNpDYVCxGpfxMPqQaMcnpvhh38zQXGtxcdz+I9UECdCW1NPU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NCbMYt/U; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NCbMYt/U" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-55b93104888so4506041e87.1; Sun, 10 Aug 2025 05:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754830680; x=1755435480; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fLpTR6tAuSk7MmdRr1bx3cY7Ji1Fi9DhOlpvPdNYklM=; b=NCbMYt/U4MIDHV68kIz6cRr4GvYdlL8tP+LHvM20vkHvNFvNUjGAI9CBF7fXo9rI3T jEDFMQ6VCA/wUsWT2uGz5SXyuaR5fIJtV8kZ88cbyu90zouK/CrqMW4HxRZg68xpbdwF an4e30B3S6KgNO1ElGryncczmaJADREGQVQFOhT39AgQBrwohOCGVpiWeVyL10+Jh+Ij 2UhJ4u65DhO1EXsDdtv8ZWSWqcZqYL1VqINwbgLp2s1gXjaO9HULWAA6Xic3N1mI0wg7 BYck9Xp/bzfQXxuTPhZIUscUSO5wdj/I1A6jhJqzxXvE+E3xyfAwAMYBOKDRj4IKSfEg zH0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754830680; x=1755435480; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fLpTR6tAuSk7MmdRr1bx3cY7Ji1Fi9DhOlpvPdNYklM=; b=GqfA0PjHzRdq1JwwRQFrCEluS/ceLyMt01PzXqZyieohKmR5yPYT+0/8g6//OXRGTR P/kBQcpfcD7NSw9ewceuo13NEoyrSNiCb6bfPJBiRxDvcO4e9szvMN8OxSpvZFNRLzAH US9PF2CRLJT2hR0co6JE3ZshIX8TtOdkLqe0u+kac6kMCBeYSuT0ASVm8SWfclH5HabA 7fv1ZMet6lUGX9OXNcRwh3Eu2vcj1D+iUnLyOWk2yWvwtLAysD539wv9tmmc00WcFLcj WUTJx0UL4mvYSUX82yL3gLQO+aDSB38V+UbNk7si1Z1U5JImJKzS1I0ht0ZI1aeYpLyD kAAg== X-Forwarded-Encrypted: i=1; AJvYcCUxatSrdEsn9KagUhZwKeWeXJdVxOaOFMZi5FMBX1M6DQtTxhX41qDc4V762ZlWjQ9QvYTQXHZ692u2PA==@vger.kernel.org, AJvYcCVYSpp7Luigg7Yn3KWnc1sZodPOrGCoj91/gAhdzwxFoGXA8EX8qX3s86GX8hBLcHU+N3CtAcPOZKXVnIQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxuoEgfNGtiiDMfjmlqvCuqzuOFlwBQWe1tjmUBfGWOIQmNn88y uI9l+tKLFKXeym1h6xRdrJWwli0T1lnx5Vrw75hrx+KfF0jb/7cJx746 X-Gm-Gg: ASbGncsyHa2mQgw3C+hgKETmmXkVKCFYV7ZoYNTZ8DLz+w1+tMWe0DEAh1FGY8G553k MwP+oQm0qYvvbvRtdqz+xR6BBIicUcKLIqS2UAhSeRrFFl8lBum/AiMaXp7Wg8ZwTisPuEJQ2Vh xvpdZCOAaFdZJ6hFWi16QjdHYd43RWDjNFuopQLQxPQKDs7o4BwCzn/8yfKGndZ9i9qGSxmT1UT +O/9BkDG6SfcUq16TqNodn7NbLyhkjj6F1er6exp+U+B1h3J4NnWGrTTP0OxtumthbXn3lOgW7G uJ6+1sQuCD9ev1mUFrU3fZDSiCcmuRNsekF+AiU7/QVrr45Nu3DRdqEZOk4kCmyTckUJiOrWIne 4h3QXUd+61H1gWotAVoQS5vBhs0dAmK+S3+JTUQ== X-Google-Smtp-Source: AGHT+IGP/4+VH4qZJqmI6pqOQcdamwMMjmUjwyAr9JTcQGvwe1pb2iGdV8kKhr91VYx69eEOJbHKcQ== X-Received: by 2002:a05:6512:2313:b0:55b:8397:cffd with SMTP id 2adb3069b0e04-55cc00ada77mr2589766e87.9.1754830679327; Sun, 10 Aug 2025 05:57:59 -0700 (PDT) Received: from localhost.localdomain ([2a03:32c0:2e:37dd:bfc4:9fdc:ddc6:5962]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-55b88c9908esm3804561e87.76.2025.08.10.05.57.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Aug 2025 05:57:58 -0700 (PDT) From: Sabyrzhan Tasbolatov To: ryabinin.a.a@gmail.com, christophe.leroy@csgroup.eu, bhe@redhat.com, hca@linux.ibm.com, andreyknvl@gmail.com, akpm@linux-foundation.org, zhangqing@loongson.cn, chenhuacai@loongson.cn, davidgow@google.com, glider@google.com, dvyukov@google.com, alexghiti@rivosinc.com Cc: alex@ghiti.fr, agordeev@linux.ibm.com, vincenzo.frascino@arm.com, elver@google.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org, snovitoll@gmail.com Subject: [PATCH v6 0/2] kasan: unify kasan_enabled() and remove arch-specific implementations Date: Sun, 10 Aug 2025 17:57:44 +0500 Message-Id: <20250810125746.1105476-1-snovitoll@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series addresses the fragmentation in KASAN initialization across architectures by introducing a unified approach that eliminates duplicate static keys and arch-specific kasan_arch_is_ready() implementations. The core issue is that different architectures have inconsistent approaches to KASAN readiness tracking: - PowerPC, LoongArch, and UML arch, each implement own kasan_arch_is_ready() - Only HW_TAGS mode had a unified static key (kasan_flag_enabled) - Generic and SW_TAGS modes relied on arch-specific solutions or always-on behavior Changes in v6: - Call kasan_init_generic() in arch/riscv _after_ local_flush_tlb_all() - Added more details in git commit message - Fixed commenting format per coding style in UML (Christophe Leroy) - Changed exporting to GPL for kasan_flag_enabled (Christophe Leroy) - Converted ARCH_DEFER_KASAN to def_bool depending on KASAN to avoid arch users to have `if KASAN` condition (Christophe Leroy) - Forgot to add __init for kasan_init in UML Changes in v5: - Unified patches where arch (powerpc, UML, loongarch) selects ARCH_DEFER_KASAN in the first patch not to break bisectability. So in v5 we have 2 patches now in the series instead of 9. - Removed kasan_arch_is_ready completely as there is no user - Removed __wrappers in v4, left only those where it's necessary due to different implementations Tested on: - powerpc - selects ARCH_DEFER_KASAN Built ppc64_defconfig (PPC_BOOK3S_64) - OK Booted via qemu-system-ppc64 - OK I have not tested in v4 powerpc without KASAN enabled. In v4 arch/powerpc/Kconfig it was: select ARCH_DEFER_KASAN if PPC_RADIX_MMU and compiling with ppc64_defconfig caused: lib/stackdepot.o:(__jump_table+0x8): undefined reference to `kasan_flag_enabled' I have fixed it in v5 via adding KASAN condition: select ARCH_DEFER_KASAN if KASAN && PPC_RADIX_MMU - um - selects ARCH_DEFER_KASAN KASAN_GENERIC && KASAN_INLINE && STATIC_LINK Before: In file included from mm/kasan/common.c:32: mm/kasan/kasan.h:550:2: error: #error kasan_arch_is_ready only works in KASAN generic outline mode! 550 | #error kasan_arch_is_ready only works in KASAN generic outline mode After (with auto-selected ARCH_DEFER_KASAN): ./arch/um/include/asm/kasan.h:29:2: error: #error UML does not work in KASAN_INLINE mode with STATIC_LINK enabled! 29 | #error UML does not work in KASAN_INLINE mode with STATIC_LINK enabled! KASAN_GENERIC && KASAN_OUTLINE && STATIC_LINK && Before: ./linux boots. After (with auto-selected ARCH_DEFER_KASAN): ./linux boots. KASAN_GENERIC && KASAN_OUTLINE && !STATIC_LINK Before: ./linux boots After (with auto-disabled !ARCH_DEFER_KASAN): ./linux boots - loongarch - selects ARCH_DEFER_KASAN Built defconfig with KASAN_GENERIC - OK Haven't tested the boot. Asking Loongarch developers to verify - N/A But should be good, since Loongarch does not have specific "kasan_init()" call like UML does. It selects ARCH_DEFER_KASAN and calls kasan_init() in the end of setup_arch() after jump_label_init(). Previous v5 thread: https://lore.kernel.org/all/20250807194012.631367-1-snovitoll@gmail.com/ Previous v4 thread: https://lore.kernel.org/all/20250805142622.560992-1-snovitoll@gmail.com/ Previous v3 thread: https://lore.kernel.org/all/20250717142732.292822-1-snovitoll@gmail.com/ Previous v2 thread: https://lore.kernel.org/all/20250626153147.145312-1-snovitoll@gmail.com/ Sabyrzhan Tasbolatov (2): kasan: introduce ARCH_DEFER_KASAN and unify static key across modes kasan: call kasan_init_generic in kasan_init arch/arm/mm/kasan_init.c | 2 +- arch/arm64/mm/kasan_init.c | 4 +--- arch/loongarch/Kconfig | 1 + arch/loongarch/include/asm/kasan.h | 7 ------ arch/loongarch/mm/kasan_init.c | 8 +++---- arch/powerpc/Kconfig | 1 + arch/powerpc/include/asm/kasan.h | 12 ---------- arch/powerpc/mm/kasan/init_32.c | 2 +- arch/powerpc/mm/kasan/init_book3e_64.c | 2 +- arch/powerpc/mm/kasan/init_book3s_64.c | 6 +---- arch/riscv/mm/kasan_init.c | 1 + arch/s390/kernel/early.c | 3 ++- arch/um/Kconfig | 1 + arch/um/include/asm/kasan.h | 5 ++-- arch/um/kernel/mem.c | 13 ++++++++--- arch/x86/mm/kasan_init_64.c | 2 +- arch/xtensa/mm/kasan_init.c | 2 +- include/linux/kasan-enabled.h | 32 ++++++++++++++++++-------- include/linux/kasan.h | 6 +++++ lib/Kconfig.kasan | 12 ++++++++++ mm/kasan/common.c | 17 ++++++++++---- mm/kasan/generic.c | 19 +++++++++++---- mm/kasan/hw_tags.c | 9 +------- mm/kasan/kasan.h | 8 ++++++- mm/kasan/shadow.c | 12 +++++----- mm/kasan/sw_tags.c | 1 + mm/kasan/tags.c | 2 +- 27 files changed, 113 insertions(+), 77 deletions(-) -- 2.34.1