From: Chanho Min <chanho.min@lge.com>
To: Steve French <sfrench@samba.org>, linux-cifs@vger.kernel.org
Cc: samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
gunho.lee@lge.com, gregkh@linuxfoundation.org, sashal@kernel.org,
Paulo Alcantara <pc@manguebit.com>,
stable@vger.kernel.org, Chanho Min <chanho.min@lge.com>,
Steve French <stfrench@microsoft.com>
Subject: [PATCH 3/4] smb: client: fix potential UAF in smb2_is_valid_lease_break()
Date: Mon, 11 Aug 2025 18:46:38 +0900 [thread overview]
Message-ID: <20250811094639.37446-4-chanho.min@lge.com> (raw)
In-Reply-To: <20250811094639.37446-1-chanho.min@lge.com>
From: Paulo Alcantara <pc@manguebit.com>
Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.
Cc: stable@vger.kernel.org # 5.4
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
[ chanho: Backported to v5.4.y, smb2misc.c was moved from fs/cifs to fs/smb/client ]
Signed-off-by: Chanho Min <chanho.min@lge.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
---
fs/cifs/smb2misc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/cifs/smb2misc.c b/fs/cifs/smb2misc.c
index d7cbf1b07126c..c47927d257635 100644
--- a/fs/cifs/smb2misc.c
+++ b/fs/cifs/smb2misc.c
@@ -611,7 +611,8 @@ smb2_is_valid_lease_break(char *buffer)
list_for_each(tmp1, &server->smb_ses_list) {
ses = list_entry(tmp1, struct cifs_ses, smb_ses_list);
-
+ if (cifs_ses_exiting(ses))
+ continue;
list_for_each(tmp2, &ses->tcon_list) {
tcon = list_entry(tmp2, struct cifs_tcon,
tcon_list);
next prev parent reply other threads:[~2025-08-11 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 9:46 [PATCH 0/4] smb: Backport UAF fixes for v5.4.y Chanho Min
2025-08-11 9:46 ` [PATCH 1/4] smb: client: fix potential UAF in cifs_debug_files_proc_show() Chanho Min
2025-08-11 9:46 ` [PATCH 2/4] smb: client: fix potential UAF in is_valid_oplock_break() Chanho Min
2025-08-11 9:46 ` Chanho Min [this message]
2025-08-11 9:46 ` [PATCH 4/4] smb: client: fix potential UAF in cifs_stats_proc_write() Chanho Min
2025-08-24 8:47 ` [PATCH 0/4] smb: Backport UAF fixes for v5.4.y Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250811094639.37446-4-chanho.min@lge.com \
--to=chanho.min@lge.com \
--cc=gregkh@linuxfoundation.org \
--cc=gunho.lee@lge.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=samba-technical@lists.samba.org \
--cc=sashal@kernel.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®