From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 752522BF005 for ; Wed, 13 Aug 2025 05:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755064553; cv=none; b=XfKaJIvDtmNmYMU1LEJsMPk+Yh6e+sB9aki1UhGkWclZq56wLB0Gr4WSyOZRvt9tI8DSGT00CJSvIm9LTuvXpmMBq7mqYSN7n1mpfIt9OdbrRN7WgX/WdBzLtHiOP082plGKNOZFGTATcua/SMkacTuetZIAaFKsh+wHag+wfhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755064553; c=relaxed/simple; bh=ZCrNgGejmOqVj4XFPaXw8CoNIHxHwb4RQH/AZeUJnCE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=RyutCgsseXtMIvWbAw3FK5vh3tReNQ/obtke7JMrmYFp50Qwi2IE/1T2kl0tIjc3MNPiDRe8Vbhxnz/aDTVWQHe3lU8FZwyyozpbrxJJ0dUqdKc6yhP4USbQlOTa1sj/QQ3iQEE5BYFMiE3UU0NdxuiJyBFN1Iy9ov28/r4l0Uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wQLx4lhc; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--kuniyu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wQLx4lhc" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-243049e6e1dso21560125ad.3 for ; Tue, 12 Aug 2025 22:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755064552; x=1755669352; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7BRD/FiSa0hIxPhbV2v5R9dmUKhZt4vQoKPKl+drGfw=; b=wQLx4lhcTlnU+/K657a4iWEN68/lz4lFvhVH9EA6IVgd9iEPZU9np6HNeHWttl9uxz ykKZpVNo+l0QDVcU/8LPE1ObGYph354TaIWmMxYvdkynaoRIjuEOHzbWsd0WMsXfX8Pp IveUDRkJ/nzhLmU5azQXhnlra/mBZAnP79sOXxx3GQm2OUXtKT5FiBcV73ODw5Tz1+vR ZLIyfSFgTSIdKnuFYQ1WE0B3SmtejIh0MDZKg3bNV3VmxUe1oL8LrrZD6fmMoCuGG9x2 IybPoFlFxvSGr+az3UBuy3Sw4CFl3YHFRgNx2P7zT38LlLrIOHQvrLO+3Wc/jkBZ7tMR 4e5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755064552; x=1755669352; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7BRD/FiSa0hIxPhbV2v5R9dmUKhZt4vQoKPKl+drGfw=; b=gCUy9xFijy5ru3pRPBl0HavXSB4EHQhdXahFIlk6sz2QEIsJpq5NrdLbW8rWbdq1EI /IHhmB4VGOBjBummGgwltUrC05Mh6dqC/oPvYBozWbBv1nGwf8WPm2U3raLYpl7qDkjw jQFRlX2W6yizjgJBQ1dICcpAuOkYLQi+L6bwVbvsM0a4kMxkBZX6MUAPeLkSDDBlZxH/ C0IE9kMG9M6Vf6YB3X7YDZBGRMVyIgy7tU9mA5XAJF+EHgTXOW0KFLCGTmYP7FnD84kw GXkQJ3HfUgANWWLlrs/M0E/15nDEcQBhDw30EBQTAb3bOZ28axVp/G+Ls4R9wzJgepDM Twdw== X-Forwarded-Encrypted: i=1; AJvYcCXxUztTYCyEXMqfU77xIMpj2KyAnGeV1HQBssZPlTSpKWQiiC+kRgdaso30Uw1CWmTMJaYGs/L06VJR8Go=@vger.kernel.org X-Gm-Message-State: AOJu0YxHxE086BX4Knj0AGyrHuw+62TJTXbq/UraZ8dUeqE9LelknUea Wz1lXKDxItR3Pw5k4JySLIPyiKxTnrf5TWWBbRc1X9+3nHM8Qs4WE7SMd8/DkFvEumMD12klUvK 9DISg9w== X-Google-Smtp-Source: AGHT+IFoxYNoLghmdpptP7tDhzLk87CD3oeZhiQZUU42sNUj217+eYJVUow5Fo+S87ldA3ZHGB6RAPq/1Sw= X-Received: from pjbsq11.prod.google.com ([2002:a17:90b:530b:b0:321:c475:716e]) (user=kuniyu job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:e812:b0:23f:c760:fdf0 with SMTP id d9443c01a7336-2430d1f71e5mr29923185ad.45.1755064551813; Tue, 12 Aug 2025 22:55:51 -0700 (PDT) Date: Wed, 13 Aug 2025 05:55:48 +0000 In-Reply-To: <20250813014819.262405-2-dqfext@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250813014819.262405-2-dqfext@gmail.com> X-Mailer: git-send-email 2.51.0.rc0.205.g4a044479a3-goog Message-ID: <20250813055550.98488-1-kuniyu@google.com> Subject: Re: [PATCH net v2 2/2] net: ethernet: mtk_ppe: add RCU lock around dev_fill_forward_path From: Kuniyuki Iwashima To: dqfext@gmail.com Cc: andrew+netdev@lunn.ch, angelogioacchino.delregno@collabora.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, lorenzo@kernel.org, matthias.bgg@gmail.com, nbd@nbd.name, netdev@vger.kernel.org, pabeni@redhat.com, sean.wang@mediatek.com Content-Type: text/plain; charset="UTF-8" From: Qingfang Deng Date: Wed, 13 Aug 2025 09:48:18 +0800 > Ensure ndo_fill_forward_path() is called with RCU lock held. > > Fixes: 2830e314778d ("net: ethernet: mtk-ppe: fix traffic offload with bridged wlan") > Signed-off-by: Qingfang Deng > --- > v2: New patch > > drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c > index c855fb799ce1..e9bd32741983 100644 > --- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c > +++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c > @@ -101,7 +101,9 @@ mtk_flow_get_wdma_info(struct net_device *dev, const u8 *addr, struct mtk_wdma_i > if (!IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED)) > return -1; > > + rcu_read_lock(); > err = dev_fill_forward_path(dev, addr, &stack); > + rcu_read_unlock(); This should be squashed to patch 1 or reorded as patch 1. > if (err) > return err; > > -- > 2.43.0 >