From: Yazen Ghannam <yazen.ghannam@amd.com>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, Libing He <libhe@redhat.com>,
Mario Limonciello <mario.limonciello@amd.com>,
David Arcari <darcari@redhat.com>
Subject: Re: [PATCH v2] x86/CPU/AMD: Ignore invalid reset reason value
Date: Wed, 13 Aug 2025 15:32:24 -0400 [thread overview]
Message-ID: <20250813193224.GA52005@yaz-khff2.amd.com> (raw)
In-Reply-To: <20250723200752.2851345-1-yazen.ghannam@amd.com>
On Wed, Jul 23, 2025 at 08:07:52PM +0000, Yazen Ghannam wrote:
> The reset reason value may be "all bits set", e.g. 0xFFFFFFFF. This is a
> commonly used error response from hardware. This may occur due to a real
> hardware issue or when running in a VM.
>
> The user will see all reset reasons reported in this case.
>
> Return early if running in a VM as this register is not emulated.
>
> Check for an error response value and return early to avoid decoding
> invalid data.
>
> Also, adjust the data variable type to match the hardware register size.
>
> Fixes: ab8131028710 ("x86/CPU/AMD: Print the reason for the last reset")
> Reported-by: Libing He <libhe@redhat.com>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Cc: David Arcari <darcari@redhat.com>
> Cc: stable@vger.kernel.org
> ---
Hi all,
Any more feedback on this?
Thanks,
Yazen
prev parent reply other threads:[~2025-08-13 19:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 20:07 Yazen Ghannam
2025-07-24 4:25 ` Borislav Petkov
2025-08-13 19:32 ` Yazen Ghannam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813193224.GA52005@yaz-khff2.amd.com \
--to=yazen.ghannam@amd.com \
--cc=darcari@redhat.com \
--cc=libhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®