mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rajeev Mishra <rajeevm@hpe.com>
To: axboe@kernel.dk, yukuai1@huaweicloud.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rajeev Mishra <rajeevm@hpe.com>
Subject: [PATCH v4 1/2] loop: Rename and merge get_size/get_loop_size to lo_calculate_size
Date: Wed, 13 Aug 2025 19:52:26 +0000	[thread overview]
Message-ID: <20250813195228.12021-2-rajeevm@hpe.com> (raw)
In-Reply-To: <20250813195228.12021-1-rajeevm@hpe.com>

- Renamed get_size to lo_calculate_size.
- Merged get_size and get_loop_size logic into lo_calculate_size.
- Updated all callers to use lo_calculate_size.
- Added header to lo_calculate_size.

Signed-off-by: Rajeev Mishra <rajeevm@hpe.com>
---
 drivers/block/loop.c | 50 +++++++++++++++++++-------------------------
 1 file changed, 21 insertions(+), 29 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 1b6ee91f8eb9..5faf8607dfb2 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -137,30 +137,23 @@ static void loop_global_unlock(struct loop_device *lo, bool global)
 static int max_part;
 static int part_shift;
 
-static loff_t get_size(loff_t offset, loff_t sizelimit, struct file *file)
-{
-	loff_t loopsize;
-
-	/* Compute loopsize in bytes */
-	loopsize = i_size_read(file->f_mapping->host);
-	if (offset > 0)
-		loopsize -= offset;
-	/* offset is beyond i_size, weird but possible */
-	if (loopsize < 0)
-		return 0;
-
-	if (sizelimit > 0 && sizelimit < loopsize)
-		loopsize = sizelimit;
-	/*
-	 * Unfortunately, if we want to do I/O on the device,
-	 * the number of 512-byte sectors has to fit into a sector_t.
-	 */
-	return loopsize >> 9;
-}
-
-static loff_t get_loop_size(struct loop_device *lo, struct file *file)
-{
-	return get_size(lo->lo_offset, lo->lo_sizelimit, file);
+static loff_t lo_calculate_size(struct loop_device *lo, struct file *file)
+{
+       loff_t loopsize;
+       /* Compute loopsize in bytes */
+       loopsize = i_size_read(file->f_mapping->host);
+       if (lo->lo_offset > 0)
+	       loopsize -= lo->lo_offset;
+       /* offset is beyond i_size, weird but possible */
+       if (loopsize < 0)
+	       return 0;
+       if (lo->lo_sizelimit > 0 && lo->lo_sizelimit < loopsize)
+	       loopsize = lo->lo_sizelimit;
+       /*
+	* Unfortunately, if we want to do I/O on the device,
+	* the number of 512-byte sectors has to fit into a sector_t.
+	*/
+       return loopsize >> 9;
 }
 
 /*
@@ -569,7 +562,7 @@ static int loop_change_fd(struct loop_device *lo, struct block_device *bdev,
 	error = -EINVAL;
 
 	/* size of the new backing store needs to be the same */
-	if (get_loop_size(lo, file) != get_loop_size(lo, old_file))
+	if (lo_calculate_size(lo, file) != lo_calculate_size(lo, old_file))
 		goto out_err;
 
 	/*
@@ -1063,7 +1056,7 @@ static int loop_configure(struct loop_device *lo, blk_mode_t mode,
 	loop_update_dio(lo);
 	loop_sysfs_init(lo);
 
-	size = get_loop_size(lo, file);
+	size = lo_calculate_size(lo, file);
 	loop_set_size(lo, size);
 
 	/* Order wrt reading lo_state in loop_validate_file(). */
@@ -1255,8 +1248,7 @@ loop_set_status(struct loop_device *lo, const struct loop_info64 *info)
 	if (partscan)
 		clear_bit(GD_SUPPRESS_PART_SCAN, &lo->lo_disk->state);
 	if (!err && size_changed) {
-		loff_t new_size = get_size(lo->lo_offset, lo->lo_sizelimit,
-					   lo->lo_backing_file);
+		loff_t new_size = lo_calculate_size(lo, lo->lo_backing_file);
 		loop_set_size(lo, new_size);
 	}
 out_unlock:
@@ -1399,7 +1391,7 @@ static int loop_set_capacity(struct loop_device *lo)
 	if (unlikely(lo->lo_state != Lo_bound))
 		return -ENXIO;
 
-	size = get_loop_size(lo, lo->lo_backing_file);
+	size = lo_calculate_size(lo, lo->lo_backing_file);
 	loop_set_size(lo, size);
 
 	return 0;
-- 
2.43.7


  reply	other threads:[~2025-08-13 19:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 19:52 [PATCH v4 0/2] review of v3 loop: use vfs_getattr_nosec() Rajeev Mishra
2025-08-13 19:52 ` Rajeev Mishra [this message]
2025-08-14  6:38   ` [PATCH v4 1/2] loop: Rename and merge get_size/get_loop_size to lo_calculate_size Yu Kuai
2025-08-13 19:52 ` [PATCH v4 2/2] loop: use vfs_getattr_nosec for accurate file size Rajeev Mishra
2025-08-14 19:10 [PATCH v4 1/2] loop: Rename and merge get_size/get_loop_size to lo_calculate_size Rajeev Mishra
2025-08-18  2:29 ` Yu Kuai
2025-08-18 16:18 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250813195228.12021-2-rajeevm@hpe.com \
    --to=rajeevm@hpe.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yukuai1@huaweicloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®