From: Inochi Amaoto <inochiama@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Marc Zyngier <maz@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Shradha Gupta <shradhagupta@linux.microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Inochi Amaoto <inochiama@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huwei.com>,
Juergen Gross <jgross@suse.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Chen Wang <unicorn_wang@outlook.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Yixun Lan <dlan@gentoo.org>, Longbin Li <looong.bin@gmail.com>
Subject: [PATCH v2 0/4] irqchip/sg2042-msi: Fix broken affinity setting
Date: Thu, 14 Aug 2025 07:28:30 +0800 [thread overview]
Message-ID: <20250813232835.43458-1-inochiama@gmail.com> (raw)
When using NVME on SG2044, the NVME always complains "I/O tag XXX
(XXX) QID XX timeout, completion polled", which is caused by the
broken handler of the sg2042-msi driver.
As PLIC driver can only setting affinity when enabling, the sg2042-msi
does not properly handled affinity setting previously and enable irq in
an unexpected executing path.
Add irq_startup/irq_shutdown support to the PCI template domain,
then set irq_chip_[startup/shutdown]_parent for irq_startup/
irq_shutdown of the sg2042-msi driver. So the irq can be started
properly.
Change from v1:
1. patch 1: Fix comment format problem, and structure the changelog.
2. patch 2: Improve the comment title and body, add describtion about
the fact the PLIC is used as parent chip.
3. patch 2: Remove __always_inline for cond_[shutdown/startup]_parent().
4. patch 3: Update the align of the "XXX_MSI_FLAGS_XXX" macro.
5. patch 4: Claim the fact that the added flag is used by the negotiation
of MSI controller driver and PCIe device driver, and can be
only used when both of them support this flag.
Inochi Amaoto (4):
genirq: Add irq_chip_(startup/shutdown)_parent()
PCI/MSI: Add startup/shutdown for per device domains
irqchip/sg2042-msi: Fix broken affinity setting
irqchip/sg2042-msi: Set MSI_FLAG_MULTI_PCI_MSI flags for SG2044
drivers/irqchip/irq-sg2042-msi.c | 19 +++++++++---
drivers/pci/msi/irqdomain.c | 52 ++++++++++++++++++++++++++++++++
include/linux/irq.h | 2 ++
include/linux/msi.h | 2 ++
kernel/irq/chip.c | 37 +++++++++++++++++++++++
5 files changed, 107 insertions(+), 5 deletions(-)
--
2.50.1
next reply other threads:[~2025-08-13 23:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 23:28 Inochi Amaoto [this message]
2025-08-13 23:28 ` [PATCH v2 1/4] genirq: Add irq_chip_(startup/shutdown)_parent() Inochi Amaoto
2025-08-23 19:28 ` [tip: irq/core] " tip-bot2 for Inochi Amaoto
2025-08-13 23:28 ` [PATCH v2 2/4] PCI/MSI: Add startup/shutdown for per device domains Inochi Amaoto
2025-08-20 20:54 ` Bjorn Helgaas
2025-08-23 19:08 ` Thomas Gleixner
2025-08-23 19:30 ` [tip: irq/drivers] " tip-bot2 for Inochi Amaoto
2025-08-26 19:45 ` [PATCH v2 2/4] " Anders Roxell
2025-08-26 22:09 ` Nathan Chancellor
2025-08-27 10:33 ` Mark Brown
2025-08-26 22:33 ` Inochi Amaoto
2025-08-26 23:28 ` Inochi Amaoto
2025-08-27 0:47 ` Nathan Chancellor
2025-08-27 8:17 ` Naresh Kamboju
2025-08-27 9:45 ` Inochi Amaoto
2025-08-27 9:44 ` Inochi Amaoto
2025-08-27 9:39 ` Wei Fang
2025-08-27 10:14 ` Chen Wang
2025-08-27 10:14 ` Inochi Amaoto
2025-08-13 23:28 ` [PATCH v2 3/4] irqchip/sg2042-msi: Fix broken affinity setting Inochi Amaoto
2025-08-23 19:30 ` [tip: irq/drivers] " tip-bot2 for Inochi Amaoto
2025-08-13 23:28 ` [PATCH v2 4/4] irqchip/sg2042-msi: Set MSI_FLAG_MULTI_PCI_MSI flags for SG2044 Inochi Amaoto
2025-08-23 19:30 ` [tip: irq/drivers] " tip-bot2 for Inochi Amaoto
2025-08-21 6:38 ` [PATCH v2 0/4] irqchip/sg2042-msi: Fix broken affinity setting Chen Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813232835.43458-1-inochiama@gmail.com \
--to=inochiama@gmail.com \
--cc=Jonathan.Cameron@huwei.com \
--cc=bhelgaas@google.com \
--cc=dlan@gentoo.org \
--cc=haiyangz@microsoft.com \
--cc=jgg@ziepe.ca \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=looong.bin@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=nicolinc@nvidia.com \
--cc=shradhagupta@linux.microsoft.com \
--cc=tglx@linutronix.de \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®