mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Nanji Parmar (he/him)" <nparmar@purestorage.com>,
	lance.yang@linux.dev, mhiramat@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hung_task: Skip hung task detection during core dump operations
Date: Thu, 14 Aug 2025 15:58:25 +0900	[thread overview]
Message-ID: <20250814155825.851f99458a7be18069fc49aa@kernel.org> (raw)
In-Reply-To: <20250813150155.81680178704c4652fd454a80@linux-foundation.org>

On Wed, 13 Aug 2025 15:01:55 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 13 Aug 2025 11:30:36 -0700 "Nanji Parmar (he/him)" <nparmar@purestorage.com> wrote:
> 
> > Tasks involved in core dump operations can legitimately block for
> > extended periods, especially for large memory processes. The hung
> > task detector should skip tasks with PF_DUMPCORE (main dumping
> > thread) or PF_POSTCOREDUMP (other threads in the group) flags to
> > avoid false positive warnings.
> > 
> > This prevents incorrect hung task reports during legitimate core
> > dump generation that can take xx minutes for large processes.
> 
> It isn't pleasing to be putting coredump special cases into the core of
> the hung-task detector.  Perhaps the hung task detector should get an
> equivalent to touch_softlockup_watchdog().  I'm surprised it doesn't
> already have such a thing.  Maybe it does and I've forgotten where it is.

Hmm, maybe we can increase nvcsw/nivcsw to reset the hung task checker.
But usually this means the task does context switch while core-dump.

> 
> Please provide a full description of the problem, mainly the relevant
> dmesg output.  Please always provide this full description when
> addressing kernel issues, thanks.

+1, dmesg will show where (in kernel) we hit the hung_task during core dump.

Thanks,

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

      parent reply	other threads:[~2025-08-14  6:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 18:30 Nanji Parmar (he/him)
2025-08-13 22:01 ` Andrew Morton
2025-08-14  3:12   ` Lance Yang
     [not found]     ` <CAEK+-Od=j88QND5pZ-K_23fwmacy9enxogzNLxH4PjPYotDh9A@mail.gmail.com>
2025-08-14  4:30       ` Lance Yang
2025-08-14  6:58   ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250814155825.851f99458a7be18069fc49aa@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=lance.yang@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nparmar@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®