From: Greg KH <gregkh@linuxfoundation.org>
To: Wang Wensheng <wangwensheng4@huawei.com>
Cc: rafael@kernel.org, dakr@kernel.org, robh@kernel.org,
broonie@kernel.org, saravanak@google.com,
linux-kernel@vger.kernel.org, chenjun102@huawei.com
Subject: Re: [PATCH v2] driver core: Fix concurrent problem of deferred_probe_extend_timeout()
Date: Thu, 14 Aug 2025 16:19:59 +0200 [thread overview]
Message-ID: <2025081451-police-playlist-3f9b@gregkh> (raw)
In-Reply-To: <20250814122949.9024-1-wangwensheng4@huawei.com>
On Thu, Aug 14, 2025 at 08:29:49PM +0800, Wang Wensheng wrote:
> The deferred_probe_timeout_work may be canceled forever unexpected when
> deferred_probe_extend_timeout() executes concurrently. Start with
> deferred_probe_timeout_work pending, and the problem would
> occur after the following sequence.
>
> CPU0 CPU1
> deferred_probe_extend_timeout
> -> cancel_delayed_work => true
> deferred_probe_extend_timeout
> -> cancel_delayed_wrok
> -> __cancel_work
> -> try_grab_pending
> -> schedule_delayed_work
> -> queue_delayed_work_on
> since pending bit is grabbed,
> just return without doing anything
> -> set_work_pool_and_clear_pending
> this __cancel_work return false and
> the work would never be queued again
>
> The root cause is that the PENDING_BIT of the work_struct would be set
> temporaily in __cancel_work and this bit could prevent the work_struct
> to be queued in another CPU.
>
> Use deferred_probe_mutex to protect the cancel and queue operations for
> the deferred_probe_timeout_work to fix this problem.
>
> Fixes: 2b28a1a84a0e ("driver core: Extend deferred probe timeout on driver registration")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
> ---
> drivers/base/dd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 13ab98e033ea..00419d2ee910 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -323,6 +323,7 @@ static DECLARE_DELAYED_WORK(deferred_probe_timeout_work, deferred_probe_timeout_
>
> void deferred_probe_extend_timeout(void)
> {
> + guard(mutex)(&deferred_probe_mutex);
But if you grab the lock here, in the probe timeout function, the lock
will be grabbed again, causing a deadlock, right? If not, why not?
Have you run this patch with lockdep enabled?
This feels broken to me, what am I missing?
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-14 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 12:29 Wang Wensheng
2025-08-14 14:19 ` Greg KH [this message]
2025-08-14 18:16 ` Saravana Kannan
2025-08-15 1:56 ` wangwensheng (C)
2025-08-15 1:43 ` wangwensheng (C)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025081451-police-playlist-3f9b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=chenjun102@huawei.com \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=wangwensheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®