From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A42029B8DD for ; Fri, 15 Aug 2025 20:14:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755288880; cv=none; b=ETqhPkTv4VE1TsSPaG8sc9E+ldaWDGwWfotHDk73C+DErGNLgXe+tB1exZ+1xXe0n2OR1dx33EQIq9qepWTaszztQUzMFnRv18iq4CRtmcdqGl2fgj9A0vNos0s2jzWyaXGGJ8b9lowj3cbsaaeqECRNzJhjeRovQc16Nx5mKhg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755288880; c=relaxed/simple; bh=gPLPrgsC04mCj1/YNA/33OZmUtgG2yG+9SpPvMJTiys=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SmwT0p40dUH1Nnem3N5MHfO3wD7hXBp0Wc7uEoUtfLnpH1J+bszGkZrZWqOiGgwXMj4tcJ/7DatonGUUBa1cwxWyQoT3oaC7WLR0DWHXCiawQEquUzEgf0+2fYMM5W633K/4MfPnAlFL2EJi+aQMdUVMj6MaiVQxDCgPscmzM8s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=DEN4zXX0; arc=none smtp.client-ip=209.85.166.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="DEN4zXX0" Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3e57002bc23so10913515ab.3 for ; Fri, 15 Aug 2025 13:14:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1755288877; x=1755893677; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oiZcsRXblDK+QsurtCHU3wPd/EqkMipNd3cgRBpokNI=; b=DEN4zXX0g5wv4pwMd9nNehrcNi9sHM3eNhCz8bMEvAJlq2Cb3FDM0CSIGzM+H4m2eP 1i2ap60dfF1GRai4YNn6rJr9UFyW2k6uK35mIQL/fuzPdpFycZVktaaS+dH3mK9npEg3 2t/14qA1RXuKeET4ix1g+g1i5T5PIOZiC4w62QVqC3757THMKGvKsVtOaYHT1uE2Gwu+ XYjcqyrv6VnJEL5Tw4BTKUkNWXvGz/mcnUhB8yP/Af/e1tlkym0nH2/k5UqT6Oq3VZkx jo3WwjLmHAkN+SpbC9GjPRXfA8ZLEZp+OcOjjnJr3+H3tOEyW0xYkVnKoGFdgjCjFkE7 1ixA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755288877; x=1755893677; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oiZcsRXblDK+QsurtCHU3wPd/EqkMipNd3cgRBpokNI=; b=Lzc+yUwdm+wzBH0esuUf8b+zIzszG7bm+7OTLeBd04wIy7gC3bnfMdCDAciYoAc+wy P9K66Emqq4bgr1V9A1yL/cPTEorg930jEqlzM1NSeZdTUcUsuzMlC+DYaTZlYVhEtLqq NF1U3BTyJiksYvDeJsf6f8Q+l2ya3ePFk+YeAupZkeIay0tfrMHAsd5rWmVGCvuHJYpD Bejl9sDOFXX1AribUAvyBiBW9wvh/zQ0KZO2SLwg7RU6VGpmFlkwAPRfMeJ+SvzcSuT/ ngzwL4f6EWYkVX/iSTPa9SI512TxOzMvJgMDr9iiPUL4Z8ocG+VBSvMjmDe6GSWgMp// L0CA== X-Forwarded-Encrypted: i=1; AJvYcCWMzeOyqj67pwyMoMSIoclCP2n7TEK0Bs90sIg0mJWOvsV7zcOGRpsyc3j/7tMBkquJLi/+ob9LvFPGdiU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywyb/LAOe/AaKux7U3FatO/ZJTn4k6DN6B0X/NOZj4Wkq4TbJU8 cg2M5hv0UQ88T5H6kCNYdWFOzYAtYj9snADUlviLZ2EE0/vw12gGH8AxY7DeM1YJawY= X-Gm-Gg: ASbGnctGigOxFfdItUkZHIhaL/Vef26a/WWJ1kav0rWadqV/7+rcSMZnXDD9Q1qsj9i nbV5SXpjq388no5e8wtF54lphaQWGt22Kes8o1eUTFuBhIdxOTCT0/Tyk6mXRJRUJC8PN5nzvHa 5w5564uaNylGz4/UbtMrwJHOX97XVxyC/h+7/Edj32kEGJnDEmLo+u9gOkKX1xOJK3jtwtel/SX 2BbJ7kWKx6LhGc3cupV/5LDgu1+bsdmX6ja0De0fTb31YTa+zKIGc8ktTEyxdgyu61DMyz/YTUZ dn7Iyswj2z/65kt3qh9PyX9sTkxEE+cPyzXnx4PIzK1yJGeSXGM6FDFkziT2eUZjO4th8u3zd2+ G0zc49IASMt39Jobst2cmALSq X-Google-Smtp-Source: AGHT+IExUiAjUdPYMjUNNYaE14vRBPYsuuXTciG9RIicgQedUovVnhzk5z3ol3/Zbxwlnlhc2kiZ3w== X-Received: by 2002:a05:6e02:1a4f:b0:3e5:469e:b105 with SMTP id e9e14a558f8ab-3e57e9d1a1fmr71697515ab.18.1755288877401; Fri, 15 Aug 2025 13:14:37 -0700 (PDT) Received: from localhost ([140.82.166.162]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50c947f547bsm634066173.43.2025.08.15.13.14.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Aug 2025 13:14:36 -0700 (PDT) Date: Fri, 15 Aug 2025 15:14:36 -0500 From: Andrew Jones To: Anup Patel Cc: Atish Patra , Palmer Dabbelt , Paul Walmsley , Alexandre Ghiti , Anup Patel , Paolo Bonzini , Shuah Khan , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 2/6] RISC-V: KVM: Introduce feature specific reset for SBI FWFT Message-ID: <20250815-30ccdcf30a9746a3b2443b4b@orel> References: <20250814155548.457172-1-apatel@ventanamicro.com> <20250814155548.457172-3-apatel@ventanamicro.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250814155548.457172-3-apatel@ventanamicro.com> On Thu, Aug 14, 2025 at 09:25:44PM +0530, Anup Patel wrote: > The SBI FWFT feature values must be reset upon VCPU reset so > introduce feature specific reset callback for this purpose. > > Signed-off-by: Anup Patel > --- > arch/riscv/kvm/vcpu_sbi_fwft.c | 30 ++++++++++++++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/kvm/vcpu_sbi_fwft.c b/arch/riscv/kvm/vcpu_sbi_fwft.c > index 164a01288b0a..5a3bad0f9330 100644 > --- a/arch/riscv/kvm/vcpu_sbi_fwft.c > +++ b/arch/riscv/kvm/vcpu_sbi_fwft.c > @@ -30,6 +30,13 @@ struct kvm_sbi_fwft_feature { > */ > bool (*supported)(struct kvm_vcpu *vcpu); > > + /** > + * @reset: Reset the feature value irrespective whether feature is supported or not > + * > + * This callback is mandatory > + */ > + void (*reset)(struct kvm_vcpu *vcpu); > + > /** > * @set: Set the feature value > * > @@ -75,6 +82,13 @@ static bool kvm_sbi_fwft_misaligned_delegation_supported(struct kvm_vcpu *vcpu) > return misaligned_traps_can_delegate(); > } > > +static void kvm_sbi_fwft_reset_misaligned_delegation(struct kvm_vcpu *vcpu) > +{ > + struct kvm_vcpu_config *cfg = &vcpu->arch.cfg; > + > + cfg->hedeleg &= ~MIS_DELEG; > +} > + > static long kvm_sbi_fwft_set_misaligned_delegation(struct kvm_vcpu *vcpu, > struct kvm_sbi_fwft_config *conf, > unsigned long value) > @@ -124,6 +138,11 @@ static bool kvm_sbi_fwft_pointer_masking_pmlen_supported(struct kvm_vcpu *vcpu) > return fwft->have_vs_pmlen_7 || fwft->have_vs_pmlen_16; > } > > +static void kvm_sbi_fwft_reset_pointer_masking_pmlen(struct kvm_vcpu *vcpu) > +{ > + vcpu->arch.cfg.henvcfg &= ~ENVCFG_PMM; > +} > + > static long kvm_sbi_fwft_set_pointer_masking_pmlen(struct kvm_vcpu *vcpu, > struct kvm_sbi_fwft_config *conf, > unsigned long value) > @@ -180,6 +199,7 @@ static const struct kvm_sbi_fwft_feature features[] = { > { > .id = SBI_FWFT_MISALIGNED_EXC_DELEG, > .supported = kvm_sbi_fwft_misaligned_delegation_supported, > + .reset = kvm_sbi_fwft_reset_misaligned_delegation, > .set = kvm_sbi_fwft_set_misaligned_delegation, > .get = kvm_sbi_fwft_get_misaligned_delegation, > }, > @@ -187,6 +207,7 @@ static const struct kvm_sbi_fwft_feature features[] = { > { > .id = SBI_FWFT_POINTER_MASKING_PMLEN, > .supported = kvm_sbi_fwft_pointer_masking_pmlen_supported, > + .reset = kvm_sbi_fwft_reset_pointer_masking_pmlen, > .set = kvm_sbi_fwft_set_pointer_masking_pmlen, > .get = kvm_sbi_fwft_get_pointer_masking_pmlen, > }, > @@ -321,11 +342,16 @@ static void kvm_sbi_ext_fwft_deinit(struct kvm_vcpu *vcpu) > > static void kvm_sbi_ext_fwft_reset(struct kvm_vcpu *vcpu) > { > - int i; > struct kvm_sbi_fwft *fwft = vcpu_to_fwft(vcpu); > + const struct kvm_sbi_fwft_feature *feature; > + int i; > > - for (i = 0; i < ARRAY_SIZE(features); i++) > + for (i = 0; i < ARRAY_SIZE(features); i++) { > fwft->configs[i].flags = 0; > + feature = &features[i]; > + if (feature->reset) > + feature->reset(vcpu); > + } > } > > const struct kvm_vcpu_sbi_extension vcpu_sbi_ext_fwft = { > -- > 2.43.0 > Reviewed-by: Andrew Jones