From: Cryolitia PukNgae via B4 Relay <devnull+cryolitia.uniontech.com@kernel.org>
To: Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Wangyuli@uniontech.com, Guanwentao@uniontech.com,
Zhanjun@uniontech.com, Niecheng1@uniontech.com,
Cryolitia PukNgae <cryolitia@uniontech.com>
Subject: [PATCH v2] cpupower: fix mangled powercap comment
Date: Fri, 15 Aug 2025 17:14:30 +0800 [thread overview]
Message-ID: <20250815-mangled_cpupower-v2-1-6ec877145c47@uniontech.com> (raw)
From: Cryolitia PukNgae <cryolitia@uniontech.com>
Remove leading dashes from current comments and clarify its semantics
Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
---
The current comment exhibits a clear failed patch application artifact:
1. A stray '-' prefix indicating failed line removal
2. Broken sentence structure from improper context patching
For those interested in archaeology:
What appears to be version control residue has persisted since its
initial introduction and through the 2022 kernel submission[1]. While
my archaeological efforts only trace back to the 2017 openSUSE patch[2],
the corrupted syntax suggests even older origins that remain elusive -
perhaps maintainers with longer institutional memory could shed light
on its provenance.
1. https://lore.kernel.org/all/20221123111810.16017-2-trenn@suse.de/
2. https://build.opensuse.org/request/show/535512
---
Changes in v2:
- Simplify expression
- Link to v1: https://lore.kernel.org/r/20250806-mangled_cpupower-v1-1-1a559130326b@uniontech.com
---
tools/power/cpupower/lib/powercap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/power/cpupower/lib/powercap.c b/tools/power/cpupower/lib/powercap.c
index 94a0c69e55ef5e4291b13a4218e706fa8d14e6a7..609943c829efce8045d97097b5f5e9ec86d0f519 100644
--- a/tools/power/cpupower/lib/powercap.c
+++ b/tools/power/cpupower/lib/powercap.c
@@ -87,8 +87,6 @@ int powercap_set_enabled(int mode)
/*
* Hardcoded, because rapl is the only powercap implementation
-- * this needs to get more generic if more powercap implementations
- * should show up
*/
int powercap_get_driver(char *driver, int buflen)
{
---
base-commit: 6bcdbd62bd56e6d7383f9e06d9d148935b3c9b73
change-id: 20250806-mangled_cpupower-5186789f8b2b
Best regards,
--
Cryolitia PukNgae <cryolitia@uniontech.com>
reply other threads:[~2025-08-15 9:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815-mangled_cpupower-v2-1-6ec877145c47@uniontech.com \
--to=devnull+cryolitia.uniontech.com@kernel.org \
--cc=Guanwentao@uniontech.com \
--cc=Niecheng1@uniontech.com \
--cc=Wangyuli@uniontech.com \
--cc=Zhanjun@uniontech.com \
--cc=cryolitia@uniontech.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®