From: Junnan Wu <junnan01.wu@samsung.com>
To: jasowang@redhat.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
eperezma@redhat.com, junnan01.wu@samsung.com, kuba@kernel.org,
lei19.wang@samsung.com, linux-kernel@vger.kernel.org,
mst@redhat.com, netdev@vger.kernel.org, pabeni@redhat.com,
q1.huang@samsung.com, virtualization@lists.linux.dev,
xuanzhuo@linux.alibaba.com, ying123.xu@samsung.com
Subject: Re: [PATCH net] virtio_net: adjust the execution order of function `virtnet_close` during freeze
Date: Fri, 15 Aug 2025 10:23:08 +0800 [thread overview]
Message-ID: <20250815022308.2783786-1-junnan01.wu@samsung.com> (raw)
In-Reply-To: <CACGkMEv2wMm_tb+mbgMFA2M2ZimVr1OBKre3nrYrBDVPpqVoiw@mail.gmail.com>
Sorry, I basically mean that the tx napi which caused by userspace will not be scheduled during suspend,
others can not be guaranteed, such as unfinished packets already in tx vq etc.
But after this patch, once `virtnet_close` completes,
both tx and rq napi will be disabled which guarantee their napi will not be scheduled in future.
And the tx state will be set to "__QUEUE_STATE_DRV_XOFF" correctly in `netif_device_detach`.
Thanks.
next prev parent reply other threads:[~2025-08-15 2:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250812090805epcas5p25ba25ca1c5c68bbdf9df27d95ccae4f5@epcas5p2.samsung.com>
2025-08-12 9:08 ` Junnan Wu
2025-08-14 0:23 ` Jakub Kicinski
[not found] ` <CGME20250814023554epcas5p4b3dcab50835e2da4749be1be135def20@epcas5p4.samsung.com>
2025-08-14 2:36 ` Junnan Wu
2025-08-14 4:01 ` Jason Wang
[not found] ` <CGME20250814054321epcas5p1dd83614241a15c78645e7f08d5e959c3@epcas5p1.samsung.com>
2025-08-14 5:43 ` Junnan Wu
2025-08-14 6:49 ` Jason Wang
[not found] ` <CGME20250814070809epcas5p46bc5a5fe62fd5bedc8a858ae4d28a92a@epcas5p4.samsung.com>
2025-08-14 7:08 ` Junnan Wu
2025-08-15 1:07 ` Jason Wang
[not found] ` <CGME20250815022257epcas5p3de66f4e633a87e17275c0b16b888bb4e@epcas5p3.samsung.com>
2025-08-15 2:23 ` Junnan Wu [this message]
2025-08-15 5:38 ` Jason Wang
[not found] ` <CGME20250815060604epcas5p3a6856bcd64ee4ed80abb43b09aab8a42@epcas5p3.samsung.com>
2025-08-15 6:06 ` Junnan Wu
2025-08-15 15:55 ` Jakub Kicinski
[not found] ` <CGME20250818011515epcas5p21295745d0e831fd988706877d598f913@epcas5p2.samsung.com>
2025-08-18 1:15 ` Junnan Wu
2025-08-18 15:39 ` Jakub Kicinski
2025-08-19 2:48 ` Jason Wang
[not found] ` <CGME20250819033318epcas5p3325d9c2481db3e40d776197d13f09d5a@epcas5p3.samsung.com>
2025-08-19 3:33 ` Junnan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815022308.2783786-1-junnan01.wu@samsung.com \
--to=junnan01.wu@samsung.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=lei19.wang@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=q1.huang@samsung.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=ying123.xu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®