From: Shimrra Shai <shimrrashai@gmail.com>
To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, shimrrashai@gmail.com
Subject: [PATCH 2/3] ASoC: es8323: add proper left/right mixer controls via DAPM
Date: Thu, 14 Aug 2025 23:20:22 -0500 [thread overview]
Message-ID: <20250815042023.115485-3-shimrrashai@gmail.com> (raw)
In-Reply-To: <20250815042023.115485-1-shimrrashai@gmail.com>
Add proper DAC and mixer controls to DAPM; no initialization in
es8323_probe.
Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
---
sound/soc/codecs/es8323.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/es8323.c b/sound/soc/codecs/es8323.c
index 194720e4d..79f1fa967 100644
--- a/sound/soc/codecs/es8323.c
+++ b/sound/soc/codecs/es8323.c
@@ -182,13 +182,13 @@ static const struct snd_kcontrol_new es8323_mono_adc_mux_controls =
/* Left Mixer */
static const struct snd_kcontrol_new es8323_left_mixer_controls[] = {
- SOC_DAPM_SINGLE("Left Playback Switch", SND_SOC_NOPM, 7, 1, 1),
+ SOC_DAPM_SINGLE("Left Playback Switch", ES8323_DACCONTROL17, 7, 1, 0),
SOC_DAPM_SINGLE("Left Bypass Switch", ES8323_DACCONTROL17, 6, 1, 0),
};
/* Right Mixer */
static const struct snd_kcontrol_new es8323_right_mixer_controls[] = {
- SOC_DAPM_SINGLE("Right Playback Switch", SND_SOC_NOPM, 6, 1, 1),
+ SOC_DAPM_SINGLE("Right Playback Switch", ES8323_DACCONTROL20, 7, 1, 0),
SOC_DAPM_SINGLE("Right Bypass Switch", ES8323_DACCONTROL20, 6, 1, 0),
};
--
2.48.1
next prev parent reply other threads:[~2025-08-15 4:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 4:20 [PATCH 0/3] ASoC: es8323: power and mixer controls cleanup and revision Shimrra Shai
2025-08-15 4:20 ` [PATCH 1/3] ASoC: es8323: remove DAC enablement write from es8323_probe Shimrra Shai
2025-08-15 4:20 ` Shimrra Shai [this message]
2025-08-15 4:20 ` [PATCH 3/3] ASoC: es8323: enable DAPM power widgets for playback DAC Shimrra Shai
2025-08-19 19:46 ` [PATCH 0/3] ASoC: es8323: power and mixer controls cleanup and revision Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250815042023.115485-3-shimrrashai@gmail.com \
--to=shimrrashai@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®