From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Andy Shevchenko" <andy.shevchenko@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@anaog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH] iio: iio_format_list() should set stride=1 for IIO_VAL_CHAR
Date: Sat, 16 Aug 2025 14:25:47 +0100 [thread overview]
Message-ID: <20250816142547.1c18a7e6@jic23-huawei> (raw)
In-Reply-To: <aJyP5PhTcNv8QWQL@smile.fi.intel.com>
On Wed, 13 Aug 2025 16:15:16 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Tue, Aug 12, 2025 at 10:44:13PM +0200, Andy Shevchenko wrote:
> > On Tue, Aug 12, 2025 at 1:13 PM Ben Collins <bcollins@kernel.org> wrote:
>
> ...
>
> > > Signed-off-by: Ben Collins <bcollins@kernel.org>
> >
> > Please, keep the Cc list after the '---' line (note, you may have more
> > than a single one in the patch, hence you may just add it here). This
> > will reduce the unneeded noise in the commit message as the very same
> > information will be available in the email headers and in lore
> > archive.
> >
> > > Cc: Jonathan Cameron <jic23@kernel.org>
> > > Cc: David Lechner <dlechner@baylibre.com>
> > > Cc: Nuno Sá <nuno.sa@analog.com>
> > > Cc: Andy Shevchenko <andy@kernel.org>
> > >
> > > ---
> > > drivers/iio/industrialio-core.c | 1 +
> > > 1 file changed, 1 insertion(+)
>
> Forgot to add that no need to resend just for _this_ case, take the above
> advice for the future contributions. I hope Jonathan may remove these Cc from
> the commit message.
>
Tweaked that and applied.
Thanks,
Jonathan
prev parent reply other threads:[~2025-08-16 13:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 11:12 Ben Collins
2025-08-12 14:14 ` David Lechner
2025-08-12 20:44 ` Andy Shevchenko
2025-08-13 13:15 ` Andy Shevchenko
2025-08-16 13:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250816142547.1c18a7e6@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@anaog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®