From: JiangJianJun <jiangjianjun3@huawei.com>
To: <James.Bottomley@HansenPartnership.com>,
<martin.petersen@oracle.com>, <linux-scsi@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <hare@suse.de>,
<bvanassche@acm.org>, <michael.christie@oracle.com>,
<hch@infradead.org>, <haowenchao22@gmail.com>,
<john.g.garry@oracle.com>, <hewenliang4@huawei.com>,
<yangyun50@huawei.com>, <wuyifeng10@huawei.com>,
<wubo40@huawei.com>, <yangxingui@h-partners.com>
Subject: [PATCH 00/14] scsi: scsi_error: Introduce new error handle mechanism
Date: Sun, 17 Aug 2025 16:46:33 +0800 [thread overview]
Message-ID: <20250817084633.1409286-1-jiangjianjun3@huawei.com> (raw)
In-Reply-To: <20250816112417.3581253-1-jiangjianjun3@huawei.com>
I apologize for taking too long to test and modify these patches.Here
are the revision points, with the first two being the main ones:
1. The scsi_target.can_queue value can control the increment and
decrement operations of scsi_target.target_busy. The new error
handler also needs to adjust target_busy. Both Bart and Mike opposed
removing this control condition. In this version, I have only added
the error handler check when scsi_target.can_queue <= 0.
link: https://lore.kernel.org/linux-scsi/daba5c92-2395-4eee-b212-978fbe83b56f@oracle.com/
2. I have added callbacks for setting and clearing the error handler
in scsi_host_template. Drivers can support device or target error
handlers by setting these callbacks. I believe the advantage of this
approach is that driver developers will be aware of this feature
when they see the callback prototypes and comments, and it can be
used even without device or target initialization callbacks.
However, this means that the modparam controlling the enablement can
only be removed. I have considered adding configurations only for
the virtio_scsi and iscsi_tcp drivers.
link: https://lore.kernel.org/linux-scsi/b8350de1-6ac8-4d5f-aaa7-7b03e2f7aa93@oracle.com/
3. In scsi_eh_scmd_add, a return statement was added under the
condition of xxx_in_recovery because each branch ultimately calls
scsi_eh_scmd_add_shost, which does not fail. Therefore, continuing
further would result in duplicate additions.
4. The return type of ->is_busy was changed to bool.
I have retained the original content of Wenchao's email in cover letter.
next prev parent reply other threads:[~2025-08-17 8:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 11:24 JiangJianJun
2025-08-16 11:24 ` [PATCH 01/14] scsi: scsi_error: Define framework for LUN/target based error handle JiangJianJun
2025-08-16 11:24 ` [PATCH 02/14] scsi: scsi_error: Move complete variable eh_action from shost to sdevice JiangJianJun
2025-08-16 11:24 ` [PATCH 03/14] scsi: scsi_error: Check if to do reset in scsi_try_xxx_reset JiangJianJun
2025-08-16 11:24 ` [PATCH 04/14] scsi: scsi_error: Add helper scsi_eh_sdev_stu to do START_UNIT JiangJianJun
2025-08-16 11:24 ` [PATCH 05/14] scsi: scsi_error: Add helper scsi_eh_sdev_reset to do lun reset JiangJianJun
2025-08-16 11:24 ` [PATCH 06/14] scsi: scsi_error: Add flags to mark error handle steps has done JiangJianJun
2025-08-16 11:24 ` [PATCH 07/14] scsi: scsi_error: Add helper to handle scsi device's error command list JiangJianJun
2025-08-16 11:24 ` [PATCH 08/14] scsi: scsi_error: Add a general LUN based error handler JiangJianJun
2025-08-17 9:18 ` Markus Elfring
2025-08-16 11:24 ` [PATCH 09/14] scsi: core: increase/decrease target_busy if set " JiangJianJun
2025-08-16 11:24 ` [PATCH 10/14] scsi: scsi_error: Add helper to handle scsi target's error command list JiangJianJun
2025-08-16 23:19 ` kernel test robot
2025-08-17 2:46 ` JiangJianJun
2025-08-16 11:24 ` [PATCH 11/14] scsi: scsi_error: Add a general target based error handler JiangJianJun
2025-08-16 11:24 ` [PATCH 12/14] scsi: scsi_debug: Add params for configuring the " JiangJianJun
2025-08-16 11:24 ` [PATCH 13/14] scsi: virtio_scsi: enable LUN based error handlers JiangJianJun
2025-08-16 11:24 ` [PATCH 14/14] scsi: iscsi_tcp: enable LUN-based and target-based " JiangJianJun
2025-08-17 8:46 ` JiangJianJun [this message]
2025-08-20 12:36 ` [PATCH 00/14] scsi: scsi_error: Introduce new error handle mechanism Hannes Reinecke
2025-09-02 5:56 ` JiangJianJun
2025-09-02 6:37 ` Hannes Reinecke
2025-09-14 10:41 ` [RFC PATCH v4 0/9] " JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 1/9] scsi: scsi_error: Define framework for LUN based error handle JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 2/9] scsi: scsi_error: Move complete variable eh_action from shost to sdevice JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 3/9] scsi: scsi_error: Check if to do reset in scsi_try_xxx_reset JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 4/9] scsi: scsi_error: Add helper scsi_eh_sdev_stu to do START_UNIT JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 5/9] scsi: scsi_error: Add helper scsi_eh_sdev_reset to do lun reset JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 6/9] scsi: scsi_error: Add flags to mark error handle steps has done JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 7/9] scsi: scsi_error: Add helper to handle scsi device's error command list JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 8/9] scsi: scsi_error: Add a general LUN based error handler JiangJianJun
2025-09-14 10:41 ` [RFC PATCH v4 9/9] scsi: scsi_debug: Add params for configuring the " JiangJianJun
2025-08-22 7:39 ` [PATCH 00/14] scsi: scsi_error: Introduce new error handle mechanism Damien Le Moal
2025-09-02 5:30 ` JiangJianJun
2025-09-02 5:08 ` Damien Le Moal
2025-09-02 6:03 ` JiangJianJun
2025-09-02 5:30 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250817084633.1409286-1-jiangjianjun3@huawei.com \
--to=jiangjianjun3@huawei.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bvanassche@acm.org \
--cc=haowenchao22@gmail.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=hewenliang4@huawei.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=wubo40@huawei.com \
--cc=wuyifeng10@huawei.com \
--cc=yangxingui@h-partners.com \
--cc=yangyun50@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®