From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f73.google.com (mail-lf1-f73.google.com [209.85.167.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F602271456 for ; Mon, 18 Aug 2025 06:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755497291; cv=none; b=UGyMJJszk/orU7nf7m6CPseBK2n8Vxu/kyuJiuFbWclahQJEXb7V01picrU6eDBNOqGb5ClHE0WaBYpMYhRR46Um+xJkEdKCvlqdxmSc5jhmSXi2AoeEDz9GNxjMTzDV7jMK2AkOUzQRM6aHtIlNM0JwPfdYF5LdIZ4969eP2zE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755497291; c=relaxed/simple; bh=EngOo9UQfEus4XJDxqngZ7VXC4E4SAALrw09aOuYgNM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=cUzN6vs05FIPP8yzuin5pwSttr2WQYTkfnx6XH6fdLwYDXET+5ztXpGE9rMN9k1EsuE0Dx9DVNBM1tYmK53+6FI6oTXVyf2Tk8zWwLJ4modnpAtPrzOAsXSdCE8msoUiSnjircVT9G2JELKz3PffG2cTONe/v65yxG5u53O4+9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qvCJJjsr; arc=none smtp.client-ip=209.85.167.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qvCJJjsr" Received: by mail-lf1-f73.google.com with SMTP id 2adb3069b0e04-55ce5282ebfso2239669e87.3 for ; Sun, 17 Aug 2025 23:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1755497288; x=1756102088; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BWT2t+jJBK9sAdHInrc6uLNTa9GVH1OTBmeM2Ig7zEg=; b=qvCJJjsruqhY+OXpYmjWrwRptPCFF9b+VJ2xkHCMZZIEROmZDmsgdDIR8+si30vLFL i6kJFEDXrdwGuGHpileuGfHfzO9l2/Q6cpHOrkZMe40pRwylZtiSj897A5wPkrqOuWWa 9Ov52gZVGQ6Q2uEb7OXik/1orS4U1pjG7bDTDnFirVmbmx0QNLwGpy2tUOClS8xCd+Sp 9X10Lopo1+QBO/7nCRsOZiYPzILXQuCzMCJfw/rfOPAD6DVc+SM2w1tu7fGvw9wU9Edg CZj/v4zQerAcrmz6JkP/vtsVqmrFgMaZ9CcJUBlRwFnxfx+r/XyBZpXl9vsw9mcd/w0n 48mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755497288; x=1756102088; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BWT2t+jJBK9sAdHInrc6uLNTa9GVH1OTBmeM2Ig7zEg=; b=qo//vhqfWZyM5IFw1ZUDzZjXeKx9v8+UHwEexTqsEnOI1dKOnzuUDItmzwGKlfWmrU Ms4AaoNStQ3BZS1KhDKIn7A82CwAu7di9P8JBj0lIEsHAp7E1BRNqXcQF7l9QJMmrCY5 T35+rdv7E95QvJZlhnESq5jYfKVHoHZ6hq6OvNi/Gf4uTq3wjmSqK8gvr+SiCCNHBLHs bmYNYBOA1M0uuc45I7D3EADfutQ6FxxkI2oBo2b4mcb/Vi/jw3gK0jAIHU3yTtxudwx1 6YoBIyjtjGOa+QhjOYH4drVs2JMbvKFZaUvOcerdxmOnOANEJbj0zma+vuZXV3hAEfWk 5UDw== X-Forwarded-Encrypted: i=1; AJvYcCWaBKifmPqhF9fjDEzxWrhGopZmOaNBncBqeGWyZbzUzLd4R4gKDj6GLY6M/Rdx/sG+28RKPz2cby9z+Fk=@vger.kernel.org X-Gm-Message-State: AOJu0YxColdqdYPmnWC4ugzAzAJbGZvwjk7pY9swoh6JjcATT3TUSR5W bGCJ4byczB3vZbIGtpa2mjfbbSB/XO9+//MMzgAyVmVvV+YioRf8PCkGs2BP3lLDnl7F2ZC0Ts3 Y+mFZwA== X-Google-Smtp-Source: AGHT+IGGCOCCwfaMWb0F0aVjzApbARLSap43w9ZIM8SzF+Jg1lTj8MlMhGeg/mQmq64RFP52blM58FjhNWU= X-Received: from ljhz3.prod.google.com ([2002:a2e:9643:0:b0:330:95d2:fc9f]) (user=khtsai job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6512:15a1:b0:55b:8a78:ac2 with SMTP id 2adb3069b0e04-55ceeb5a631mr2871024e87.42.1755497288394; Sun, 17 Aug 2025 23:08:08 -0700 (PDT) Date: Mon, 18 Aug 2025 14:07:35 +0800 In-Reply-To: <20250818060757.2519126-1-khtsai@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250818060757.2519126-1-khtsai@google.com> X-Mailer: git-send-email 2.51.0.rc1.163.g2494970778-goog Message-ID: <20250818060757.2519126-2-khtsai@google.com> Subject: [PATCH 2/2] usb: dwc3: Refactor dwc3_mode_show From: Kuen-Han Tsai To: Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kuen-Han Tsai Content-Type: text/plain; charset="UTF-8" Use dwc3_mode_string as the single source of truth for mode-to-string conversion. Signed-off-by: Kuen-Han Tsai --- drivers/usb/dwc3/debugfs.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/usb/dwc3/debugfs.c b/drivers/usb/dwc3/debugfs.c index ebf03468fac4..d18bf5e32cc8 100644 --- a/drivers/usb/dwc3/debugfs.c +++ b/drivers/usb/dwc3/debugfs.c @@ -402,6 +402,7 @@ static int dwc3_mode_show(struct seq_file *s, void *unused) struct dwc3 *dwc = s->private; unsigned long flags; u32 reg; + u32 mode; int ret; ret = pm_runtime_resume_and_get(dwc->dev); @@ -412,18 +413,15 @@ static int dwc3_mode_show(struct seq_file *s, void *unused) reg = dwc3_readl(dwc->regs, DWC3_GCTL); spin_unlock_irqrestore(&dwc->lock, flags); - switch (DWC3_GCTL_PRTCAP(reg)) { + mode = DWC3_GCTL_PRTCAP(reg); + switch (mode) { case DWC3_GCTL_PRTCAP_HOST: - seq_puts(s, "host\n"); - break; case DWC3_GCTL_PRTCAP_DEVICE: - seq_puts(s, "device\n"); - break; case DWC3_GCTL_PRTCAP_OTG: - seq_puts(s, "otg\n"); + seq_printf(s, "%s\n", dwc3_mode_string(mode)); break; default: - seq_printf(s, "UNKNOWN %08x\n", DWC3_GCTL_PRTCAP(reg)); + seq_printf(s, "UNKNOWN %08x\n", mode); } pm_runtime_put_sync(dwc->dev); -- 2.51.0.rc1.163.g2494970778-goog