From: darshanrathod475@gmail.com
To: lyude@redhat.com, dakr@kernel.org, airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Darshan Rathod <darshanrathod475@gmail.com>
Subject: [PATCH] drm/nouveau: avoid assignment in if condition
Date: Mon, 18 Aug 2025 12:50:47 +0530 [thread overview]
Message-ID: <20250818072047.376046-1-darshanrathod475@gmail.com> (raw)
From: Darshan Rathod <darshanrathod475@gmail.com>
Move kzalloc assignment out of the if condition to follow
kernel coding style guidelines and improve readability.
Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>
---
drivers/gpu/drm/nouveau/nvkm/engine/falcon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/falcon.c b/drivers/gpu/drm/nouveau/nvkm/engine/falcon.c
index fd5ee9f0af36..46273e6b14ac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/falcon.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/falcon.c
@@ -262,6 +262,7 @@ nvkm_falcon_init(struct nvkm_engine *engine)
/* upload firmware bootloader (or the full code segments) */
if (falcon->core) {
u64 addr = nvkm_memory_addr(falcon->core);
+
if (device->card_type < NV_C0)
nvkm_wr32(device, base + 0x618, 0x04000000);
else
@@ -341,8 +342,10 @@ nvkm_falcon_new_(const struct nvkm_falcon_func *func, struct nvkm_device *device
{
struct nvkm_falcon *falcon;
- if (!(falcon = kzalloc(sizeof(*falcon), GFP_KERNEL)))
+ falcon = kzalloc(sizeof(*falcon), GFP_KERNEL);
+ if (!falcon)
return -ENOMEM;
+
falcon->func = func;
falcon->addr = addr;
falcon->code.data = func->code.data;
--
2.25.1
reply other threads:[~2025-08-18 7:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818072047.376046-1-darshanrathod475@gmail.com \
--to=darshanrathod475@gmail.com \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®