From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AF5A277003 for ; Mon, 18 Aug 2025 07:17:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755501460; cv=none; b=Ssg6/pekX8JCMfosjmnCYtdNpP1PksO+m97PDqlJagrEA3fO5XhGx6EcIqUKfiNJmJSGBW5bjgTR+3AbExpjEBEnO/YTRPlFGzPzhwBwTyqHUD2pSile8UGK/hiW3Ra2Fbmvr5Sk7a1ddwd9X8h1NRmkBbQQeOqQJWQrHR4DXoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755501460; c=relaxed/simple; bh=GRtOJJ4TU25SLYLaBruGe/0cKnzINtKI69UBlywJ0HU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=G/m1+RuXn3j3c5maQPDTey3YocDl+3AXLA1q+4PUUFjcU4M5xuBvAXOjUZQvKakRhSQ1C0wVA0Fo35Do6rOe6P1TeKpGxQFlgxfQV3KpaVhvtcSFa+1tt9fBZ5jcvLg22wNvAqm80dr+NsoRrC4O3Aksea4Axvx69RW4cWQKRgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=teFAK1vl; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="teFAK1vl" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3b9d41c1149so2909568f8f.0 for ; Mon, 18 Aug 2025 00:17:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755501455; x=1756106255; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=00HmFiTKWlOUviqLOmDiviucp/G1KSLyabeRXjoLhH4=; b=teFAK1vlqjAnOufj1cK0esDy07iK6gIPAZO+Kj1pmsTWtYWHEi5Damcdt8kobHlO0n +EfMwuo5qdITFKs+ESDzB91C+xpDuInUEVpmKHoQ3aVz7VNki8YCwvssIVO4QWNL1p4f 5o5KIrpybG816yrbD0w7hgF9hWhREA22eGasZUsmpmyPUwtOYkM9yrIbBKXIPmAqQLiD qgb4EJcRMokq4Iht9/A24DqEmIYFH5h92RR99dWD5xuwzF6KjFttfFa+dqDVkqOu5P/m wNnzcOdX9QvIngar97NEu59zd/7fue9bPHitIyhUfSeaGvLnsjhWKdSjDy7dSM7m7k09 N5/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755501455; x=1756106255; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=00HmFiTKWlOUviqLOmDiviucp/G1KSLyabeRXjoLhH4=; b=c+psPPYbApRxNIPedpjaWKz6164STHIU8i5dBWMLDNQXfNCVIsuIXp4PlRZB+h7Ue3 hdMOVfx1X9mtyH2b1BdtrVCLgmIJ2VPDzj52lFltXH/LORFz6Rmp75zppbxu9MyWyz+H uM1ZJ2UTAF9HPQVIQs/+dnOU9Njec/kBOcTh77boxNMDxFe35HUGZdJjyvgyQB40ISsR K853K+jLMMl8G4tNSjmdbJOk4uMyVaRCtUCWMcBYVy3A9nGtxYpQEqegc9FC7SwGu83h qiCOTXSXwIjCYqRhxpZiIJ5yT2QHz9Ms95+DlBr2NDiJ3CKqowvJk19tWrCwHDgYDhz8 9zVA== X-Forwarded-Encrypted: i=1; AJvYcCW7p4q3tTyDEo0T9V/kkZYe1if8gmcXEtEW7UvVc2Q6huwcYSkDw0U4jVuj/LthVVCVWvbhBSZqgTBHlNE=@vger.kernel.org X-Gm-Message-State: AOJu0YyWIpJOqsAFilwm4grQlEkr+RpkKTgJ+w+vsqN4LzCtlFkKyuJE wU8DhJnE9R/89puMR59yJkHX45wvVWU5XRvuGadPX+yf9AYHXiDxcXsX5iQ5YMrEQbI= X-Gm-Gg: ASbGncs5UhCOhNN+9jG99DwlHSQwbugAd4L/6M4zV+cV3zRD/gWADZ5o0NcuGqtw5KA 2qpIzHFHR5vGRfNo4lfzBGc/pjolL3aWzRhigklEMoB5ZoXgtbUakHJJJ5Ljm9zF+AYTMZG5xAI eDQWWXh+Wn8EnKkJS4CzQTF4qr+PmCl8zARL1Wp1pYzSQRJSQZVtUU92qFYs9CZDzEoBvDdFSF4 5GcM0APZj0ZI2u0gpPE8i7jHvf4xTLaJtembztfWYvLc9Hfe1Mznz3uejk7RCDuSCGn2yGgEgJu 4EybMFno7k36oQGJhN7FZ9xVlSXtGC7U8OVyYGzdFJiqqgHkvteQ8GWfwWOmhkdWhiOY4W3sAgo SD/nl6CArqyfBfxeZzvRl7NFwLoiYIC4vYtekdnGCFgo= X-Google-Smtp-Source: AGHT+IHyrx5So2JkHy8B3V9n10eIVkllRTMcnOfbIYL9Fak+QjG/0EyC3RMUePQ7ZAM0RE6YfPigZA== X-Received: by 2002:a05:6000:250c:b0:3b7:8473:31c3 with SMTP id ffacd0b85a97d-3bb6646e10amr7831271f8f.9.1755501455230; Mon, 18 Aug 2025 00:17:35 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3bb67c902dbsm11683675f8f.47.2025.08.18.00.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Aug 2025 00:17:34 -0700 (PDT) Date: Mon, 18 Aug 2025 10:17:31 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Guodong Xu , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , duje@dujemihanovic.xyz Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Alex Elder , Vivian Wang , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Guodong Xu , Troy Mitchell Subject: Re: [PATCH v4 4/8] dmaengine: mmp_pdma: Add operations structure for controller abstraction Message-ID: <202508181040.az8RxLrG-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250815-working_dma_0701_v2-v4-4-62145ab6ea30@riscstar.com> Hi Guodong, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Guodong-Xu/dt-bindings-dma-Add-SpacemiT-K1-PDMA-controller/20250815-132049 base: 062b3e4a1f880f104a8d4b90b767788786aa7b78 patch link: https://lore.kernel.org/r/20250815-working_dma_0701_v2-v4-4-62145ab6ea30%40riscstar.com patch subject: [PATCH v4 4/8] dmaengine: mmp_pdma: Add operations structure for controller abstraction config: parisc-randconfig-r072-20250818 (https://download.01.org/0day-ci/archive/20250818/202508181040.az8RxLrG-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 8.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202508181040.az8RxLrG-lkp@intel.com/ smatch warnings: drivers/dma/mmp_pdma.c:546 mmp_pdma_prep_memcpy() warn: variable dereferenced before check 'dchan' (see line 542) drivers/dma/mmp_pdma.c:712 mmp_pdma_prep_dma_cyclic() warn: variable dereferenced before check 'dchan' (see line 708) vim +/dchan +546 drivers/dma/mmp_pdma.c c8acd6aa6bed3c Zhangfei Gao 2012-09-03 536 static struct dma_async_tx_descriptor * c8acd6aa6bed3c Zhangfei Gao 2012-09-03 537 mmp_pdma_prep_memcpy(struct dma_chan *dchan, c8acd6aa6bed3c Zhangfei Gao 2012-09-03 538 dma_addr_t dma_dst, dma_addr_t dma_src, c8acd6aa6bed3c Zhangfei Gao 2012-09-03 539 size_t len, unsigned long flags) c8acd6aa6bed3c Zhangfei Gao 2012-09-03 540 { c8acd6aa6bed3c Zhangfei Gao 2012-09-03 541 struct mmp_pdma_chan *chan; 918da7ee50b22b Guodong Xu 2025-08-15 @542 struct mmp_pdma_device *pdev = to_mmp_pdma_dev(dchan->device); ^^^^^^^^^^^^^ The patch adds a new dereference c8acd6aa6bed3c Zhangfei Gao 2012-09-03 543 struct mmp_pdma_desc_sw *first = NULL, *prev = NULL, *new; c8acd6aa6bed3c Zhangfei Gao 2012-09-03 544 size_t copy = 0; c8acd6aa6bed3c Zhangfei Gao 2012-09-03 545 c8acd6aa6bed3c Zhangfei Gao 2012-09-03 @546 if (!dchan) ^^^^^^ But the old existing code assumed dchan could be NULL c8acd6aa6bed3c Zhangfei Gao 2012-09-03 547 return NULL; c8acd6aa6bed3c Zhangfei Gao 2012-09-03 548 c8acd6aa6bed3c Zhangfei Gao 2012-09-03 549 if (!len) c8acd6aa6bed3c Zhangfei Gao 2012-09-03 550 return NULL; c8acd6aa6bed3c Zhangfei Gao 2012-09-03 551 c8acd6aa6bed3c Zhangfei Gao 2012-09-03 552 chan = to_mmp_pdma_chan(dchan); [ snip ] 2b7f65b11d87f9 Joe Perches 2013-11-17 701 static struct dma_async_tx_descriptor * 2b7f65b11d87f9 Joe Perches 2013-11-17 702 mmp_pdma_prep_dma_cyclic(struct dma_chan *dchan, 2b7f65b11d87f9 Joe Perches 2013-11-17 703 dma_addr_t buf_addr, size_t len, size_t period_len, 2b7f65b11d87f9 Joe Perches 2013-11-17 704 enum dma_transfer_direction direction, 31c1e5a1350ae8 Laurent Pinchart 2014-08-01 705 unsigned long flags) 50440d74aae318 Daniel Mack 2013-08-21 706 { 50440d74aae318 Daniel Mack 2013-08-21 707 struct mmp_pdma_chan *chan; 918da7ee50b22b Guodong Xu 2025-08-15 @708 struct mmp_pdma_device *pdev = to_mmp_pdma_dev(dchan->device); ^^^^^^^^^^^^^ 50440d74aae318 Daniel Mack 2013-08-21 709 struct mmp_pdma_desc_sw *first = NULL, *prev = NULL, *new; 50440d74aae318 Daniel Mack 2013-08-21 710 dma_addr_t dma_src, dma_dst; 50440d74aae318 Daniel Mack 2013-08-21 711 50440d74aae318 Daniel Mack 2013-08-21 @712 if (!dchan || !len || !period_len) ^^^^^^ Same. 50440d74aae318 Daniel Mack 2013-08-21 713 return NULL; 50440d74aae318 Daniel Mack 2013-08-21 714 50440d74aae318 Daniel Mack 2013-08-21 715 /* the buffer length must be a multiple of period_len */ -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki