mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: wim@linux-watchdog.org, linux@roeck-us.net, krzk+dt@kernel.org,
	conor+dt@kernel.org, hauke@hauke-m.de,
	linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: lantiq,wdt: convert bindings to dtschema
Date: Mon, 18 Aug 2025 12:09:04 -0500	[thread overview]
Message-ID: <20250818170904.GA1477625-robh@kernel.org> (raw)
In-Reply-To: <20250811131104.837210-1-olek2@wp.pl>

On Mon, Aug 11, 2025 at 03:10:54PM +0200, Aleksander Jan Bajkowski wrote:
> Convert the Lantiq WDT Watchdog bindings to yaml format.
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
>  .../bindings/watchdog/lantiq,wdt.yaml         | 50 +++++++++++++++++++
>  .../bindings/watchdog/lantiq-wdt.txt          | 24 ---------
>  2 files changed, 50 insertions(+), 24 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/lantiq-wdt.txt
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml
> new file mode 100644
> index 000000000000..f1102fff2d92
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/lantiq,wdt.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/lantiq,wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Lantiq WTD watchdog
> +
> +maintainers:
> +  - Hauke Mehrtens <hauke@hauke-m.de>
> +
> +allOf:
> +  - $ref: watchdog.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - lantiq,falcon-wdt
> +          - lantiq,wdt
> +          - lantiq,xrx100-wdt
> +      - items:
> +          - enum:
> +              - lantiq,xrx200-wdt
> +              - lantiq,xrx300-wdt
> +          - const: lantiq,xrx100-wdt
> +
> +  reg:
> +    maxItems: 1
> +
> +  lantiq,rcu:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the RCU syscon node (required for
> +      "lantiq,falcon-wdt" and "lantiq,xrx100-wdt")

Express the 'required' as a schema, not freeform text.

> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    watchdog@803f0 {
> +        compatible = "lantiq,xrx200-wdt", "lantiq,xrx100-wdt";
> +        reg = <0x803f0 0x10>;
> +
> +        lantiq,rcu = <&rcu0>;
> +    };

      reply	other threads:[~2025-08-18 17:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 13:10 Aleksander Jan Bajkowski
2025-08-18 17:09 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818170904.GA1477625-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=olek2@wp.pl \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®