mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
To: David Kaplan <david.kaplan@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] x86/bugs: Simplify SSB cmdline parsing
Date: Mon, 18 Aug 2025 10:41:57 -0700	[thread overview]
Message-ID: <20250818174157.c6bzy5bgw54fopgi@desk> (raw)
In-Reply-To: <20250811142659.152248-4-david.kaplan@amd.com>

On Mon, Aug 11, 2025 at 09:26:59AM -0500, David Kaplan wrote:
> Simplify the SSB command line parsing by selecting a mitigation directly,
> as is done in most of the simpler vulnerabilities.  Use early_param instead
> of cmdline_find_option for consistency with the other mitigation
> selections.
> 
> Signed-off-by: David Kaplan <david.kaplan@amd.com>
> ---
>  arch/x86/kernel/cpu/bugs.c | 118 ++++++++++++-------------------------
>  1 file changed, 39 insertions(+), 79 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
> index 19a3891953c3..3766dff9a699 100644
> --- a/arch/x86/kernel/cpu/bugs.c
> +++ b/arch/x86/kernel/cpu/bugs.c
> @@ -2625,16 +2625,8 @@ void cpu_bugs_smt_update(void)
>  #undef pr_fmt
>  #define pr_fmt(fmt)	"Speculative Store Bypass: " fmt
>  
> -static enum ssb_mitigation ssb_mode __ro_after_init = SPEC_STORE_BYPASS_NONE;
> -
> -/* The kernel command line selection */
> -enum ssb_mitigation_cmd {
> -	SPEC_STORE_BYPASS_CMD_NONE,
> -	SPEC_STORE_BYPASS_CMD_AUTO,
> -	SPEC_STORE_BYPASS_CMD_ON,
> -	SPEC_STORE_BYPASS_CMD_PRCTL,
> -	SPEC_STORE_BYPASS_CMD_SECCOMP,
> -};
> +static enum ssb_mitigation ssb_mode __ro_after_init =
> +	IS_ENABLED(CONFIG_MITIGATION_SSB) ? SPEC_STORE_BYPASS_PRCTL : SPEC_STORE_BYPASS_NONE;

Other mitigations default to "AUTO", but not this one. Isn't that something
that attack-vector controls rely on?

  reply	other threads:[~2025-08-18 17:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 14:26 [PATCH 0/3] x86/bugs: Cleanup parameter parsing David Kaplan
2025-08-11 14:26 ` [PATCH 1/3] x86/bugs: Use early_param for spectre_v2_user David Kaplan
2025-08-14  3:19   ` Pawan Gupta
2025-08-14 13:51     ` Kaplan, David
2025-08-11 14:26 ` [PATCH 2/3] x86/bugs: Use early_param for spectre_v2 David Kaplan
2025-08-14 16:54   ` Pawan Gupta
2025-08-14 18:39     ` Kaplan, David
2025-08-11 14:26 ` [PATCH 3/3] x86/bugs: Simplify SSB cmdline parsing David Kaplan
2025-08-18 17:41   ` Pawan Gupta [this message]
2025-08-18 17:55     ` Kaplan, David
2025-08-18 18:31       ` Pawan Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250818174157.c6bzy5bgw54fopgi@desk \
    --to=pawan.kumar.gupta@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=david.kaplan@amd.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®