From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC58024DD17 for ; Mon, 18 Aug 2025 18:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755541083; cv=none; b=cNHYEudrG6vL+I/UP7Vv/BC1fB1UBujf5Blo14RAVB/WXfmd4j5JTFOmuQQlLrBnv/2Ae9Ou2Bjr0P/wO2Cq8AWwJrTXipoIylN2dKCe0MZ75RQm25ygRa7HfV+iTyoCBVgB4ZGzBCQmVk4yYV2pOA7bYGyXlODPVqnvhooqZFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755541083; c=relaxed/simple; bh=Si2VsEJ435Hpz9aDrpmWKX7tHYNWWnfoh3OSHQI95Lo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=V697a52tJg7bptKdo59owNPF8CL45LdG3nhl3S9ehKYWtczhV11SGKm/JhMN28FHaJSiTKXKum2AstFfqwI2vmW+M/Y8tAvurRnUaQeoBU3YT2yJE+AKNy8H4Qy6wM37xrJrIClhqwtsC9GBK0YTV8QfCi4XAbBa/XljVSTz9RQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DGThcSp5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DGThcSp5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44A39C4CEEB; Mon, 18 Aug 2025 18:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755541083; bh=Si2VsEJ435Hpz9aDrpmWKX7tHYNWWnfoh3OSHQI95Lo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DGThcSp5EmIH6OIMOMjHy5Sg+5LMsSPOLcKKceL23Y/OVokFATTs5cJKf92RMvu56 a0XGF/1YRoXq1FvcxPtc8A3Clr0Jl5z3JB7ycOMvDrbGHrIwYOGQUY7Z6+1swhcmts hvkEvN1S8FFkFL4snSuIvPvSpCXWK6gS9JAnynaoX1kUJl/oi5ahZyxJwGo4Q6jkK+ QSWM+SP/HvkICyA8onfG7otTJ4eFby37lUIXgidh0CJdz3txJkOIJGU5kVnmhdZtAs S4D6rFZD1J8LVmAxP1JtOy9mNM5amOc5owoUj2SBY5Fh4YFxdivYrFbwh9LcET+j6p 4x5kbQXeTStXw== From: SeongJae Park To: Chris Li Cc: SeongJae Park , Nhat Pham , Andrew Morton , Chengming Zhou , David Hildenbrand , Johannes Weiner , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Takero Funaki , Hugh Dickins Subject: Re: [PATCH v2] mm/zswap: store X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Fri, 15 Aug 2025 19:23:10 -0700 Chris Li wrote: > On Fri, Aug 15, 2025 at 5:14 PM SeongJae Park wrote: > > > > Sounds good. So in the next version (v4), I will drop compress_fail. Instead, > > I will add two new counters, namely compress_engine_fail and the new atomic > > counter, say, stored_uncompressed_pages. Please suggest better names or > > correct me if I'm missing some of your points. > > Sounds great. As I suggest in my other email, if up to me, > > "crypto_compress_fail" and "stored_incompressible_pages" Nice names, thank you! I'll send the next verison soon, following all your suggestions[1] together. [1] https://lore.kernel.org/CAF8kJuPCpnGAoz=1CBwe46ytpcR0ZUMAEWLFQce7eUWkb+0ERA@mail.gmail.com Thanks, SJ [...]