From: Andrew Jones <ajones@ventanamicro.com>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Jimmy Ho <jimmy.ho@sifive.com>,
linux-riscv@lists.infradead.org, ziyao@disroot.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, alex@ghiti.fr, cyrilbur@tenstorrent.com,
cleger@rivosinc.com, charlie@rivosinc.com, kees@kernel.org,
ben.dooks@codethink.co.uk, jszhang@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] riscv: fix using wrong load type
Date: Tue, 19 Aug 2025 13:25:49 -0500 [thread overview]
Message-ID: <20250819-aa072701b64fc0f42795e491@orel> (raw)
In-Reply-To: <D49B33DEEB859CD5+aKQltEZ8Ef3v6rB9@LT-Guozexi>
On Tue, Aug 19, 2025 at 03:20:20PM +0800, Troy Mitchell wrote:
> On Tue, Aug 19, 2025 at 03:19:17PM +0800, Troy Mitchell wrote:
> > On Tue, Aug 19, 2025 at 03:13:18PM +0800, Jimmy Ho wrote:
> > > thread_info.cpu field is 32 bits wide,
> > > but is accessed using an XLEN-bit load, which might be 64bit load, fix it
> > >
> > > Changes in v3:
> > > - replace space with tab to keep it aligned with code block
> > > - Add "Fixes" tag
> > Please add previous version link.
> >
> > >
> > > Changes in v2:
> > > - add a comment to explain why use lw instead of REG_L.
> > > - correct commit message
> > ditto.
> >
> > Additionally, I see a patch here that serves the same purpose as yours,
> Sry I forgot to put link:
> https://lore.kernel.org/all/20250722160556.2216925-4-rkrcmar@ventanamicro.com/
Ah, yes. I forgot about Radim's patch. We should go with that.
Thanks,
drew
>
> - Troy
>
> > but it's more comprehensive and was submitted earlier.
> >
> > In any case, if you'd like to proceed, here is the:
> > Acked-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> > >
> > > Fixes: 503638e0babf3 ("riscv: Stop emitting preventive sfence.vma for new vmalloc mappings")
> > > Signed-off-by: Jimmy Ho <jimmy.ho@sifive.com>
> > > ---
> > > arch/riscv/kernel/entry.S | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/riscv/kernel/entry.S b/arch/riscv/kernel/entry.S
> > > index 3a0ec6fd5956..492ae936dccd 100644
> > > --- a/arch/riscv/kernel/entry.S
> > > +++ b/arch/riscv/kernel/entry.S
> > > @@ -45,8 +45,10 @@
> > > * Computes:
> > > * a0 = &new_vmalloc[BIT_WORD(cpu)]
> > > * a1 = BIT_MASK(cpu)
> > > + *
> > > + * using lw instead of REG_L is because the thread_info.cpu field is 32 bits wide
> > > */
> > > - REG_L a2, TASK_TI_CPU(tp)
> > > + lw a2, TASK_TI_CPU(tp)
> > > /*
> > > * Compute the new_vmalloc element position:
> > > * (cpu / 64) * 8 = (cpu >> 6) << 3
> > > --
> > > 2.39.3
> > >
> > >
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-08-19 18:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 7:13 Jimmy Ho
2025-08-19 7:19 ` Troy Mitchell
2025-08-19 7:20 ` Troy Mitchell
2025-08-19 18:25 ` Andrew Jones [this message]
2025-08-19 18:23 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819-aa072701b64fc0f42795e491@orel \
--to=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=ben.dooks@codethink.co.uk \
--cc=charlie@rivosinc.com \
--cc=cleger@rivosinc.com \
--cc=cyrilbur@tenstorrent.com \
--cc=jimmy.ho@sifive.com \
--cc=jszhang@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=troy.mitchell@linux.spacemit.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®