mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: srini@kernel.org
Cc: linux-kernel@vger.kernel.org, heiko@sntech.de,
	kernel test robot <lkp@intel.com>
Subject: [PATCH] nvmem: qnap-mcu-eeprom: swap header order to fix missing type definitions
Date: Tue, 19 Aug 2025 13:10:44 +0200	[thread overview]
Message-ID: <20250819111044.2714855-1-heiko@sntech.de> (raw)

The main header for the qnap-mcu uses types without (at the moment)
including the necessary types.h header.

While there is patch pending to fix that for every use:
  https://lore.kernel.org/all/20250804130726.3180806-2-heiko@sntech.de/
this does not help the nvmem driver right now.

Swapping the order of module.h and qnap-mcu.h headers does fix the
problem locally until the main change gets merged though.

Fixes: 117c3f3014a9 ("nvmem: add driver for the eeprom in qnap-mcu controllers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202508191205.ROvIX7IA-lkp@intel.com/
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 drivers/nvmem/qnap-mcu-eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvmem/qnap-mcu-eeprom.c b/drivers/nvmem/qnap-mcu-eeprom.c
index fea1e7b91764..e18e9ff4cfce 100644
--- a/drivers/nvmem/qnap-mcu-eeprom.c
+++ b/drivers/nvmem/qnap-mcu-eeprom.c
@@ -9,8 +9,8 @@
  * Copyright (C) 2008 Wolfram Sang, Pengutronix
  */
 
-#include <linux/mfd/qnap-mcu.h>
 #include <linux/module.h>
+#include <linux/mfd/qnap-mcu.h>
 #include <linux/nvmem-provider.h>
 #include <linux/platform_device.h>
 
-- 
2.47.2


             reply	other threads:[~2025-08-19 11:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-19 11:10 Heiko Stuebner [this message]
2025-08-19 13:55 ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250819111044.2714855-1-heiko@sntech.de \
    --to=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®