From: Nam Tran <trannamatk@gmail.com>
To: rdunlap@infradead.org
Cc: lee@kernel.org, pavel@kernel.org, gregkh@linuxfoundation.org,
christophe.jaillet@wanadoo.fr, krzk+dt@kernel.org,
robh@kernel.org, conor+dt@kernel.org, corbet@lwn.net,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v13 RESEND 3/4] docs: ABI: Document LP5812 LED sysfs interfaces
Date: Tue, 19 Aug 2025 23:29:45 +0700 [thread overview]
Message-ID: <20250819162945.231085-1-trannamatk@gmail.com> (raw)
In-Reply-To: <1075a908-23d0-4a9e-97d2-cb68d1d6b675@infradead.org>
On Sun, 17 Aug 2025, Randy Dunlap wrote:
> > +What: /sys/class/leds/led_<id>/lod_lsd
> > +Date: July 2025
> > +KernelVersion: 6.17
> > +Contact: Nam Tran <trannamatk@gmail.com>
> > +Description:
> > + 0 0 mean no lod and lsd fault detected, 1 1 mean lod and lsd fault detected (RO)
>
> At first the "0 0" and "1 1" confused me (thought it was a typo),
> but I think what you are showing here is a sysfs file with 2 values, right?
> That used to be discouraged (or even nacked), although I don't know the
> current policy on that.
The lod_lsd sysfs file currently reports two values: the first value is the LOD
(LED open detection) fault status, the first value is the LOD (LED open detection)
fault status.
I followed this approach to keep the two related fault bits in a single file, but
I'm open to splitting them into separate sysfs entries if that is preferred.
Best regards,
Nam Tran
next prev parent reply other threads:[~2025-08-19 16:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 1:26 [PATCH v13 RESEND 0/4] leds: add new LED driver for TI LP5812 Nam Tran
2025-08-18 1:26 ` [PATCH v13 RESEND 1/4] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver Nam Tran
2025-08-18 2:31 ` Rob Herring (Arm)
2025-08-19 16:10 ` Nam Tran
2025-08-18 1:26 ` [PATCH v13 RESEND 2/4] leds: add basic support for " Nam Tran
2025-09-02 12:11 ` Lee Jones
2025-09-04 16:17 ` Nam Tran
2025-08-18 1:26 ` [PATCH v13 RESEND 3/4] docs: ABI: Document LP5812 LED sysfs interfaces Nam Tran
2025-08-18 2:07 ` Randy Dunlap
2025-08-19 16:29 ` Nam Tran [this message]
2025-08-18 1:26 ` [PATCH v13 RESEND 4/4] docs: leds: Document TI LP5812 LED driver Nam Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819162945.231085-1-trannamatk@gmail.com \
--to=trannamatk@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®