From: Andrew Morton <akpm@linux-foundation.org>
To: Xiang Gao <gxxa03070307@gmail.com>
Cc: david@redhat.com, lorenzo.stoakes@oracle.com,
Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, gaoxiang17 <gaoxiang17@xiaomi.com>
Subject: Re: [PATCH] mm/cma: add 'available count' and 'total count' to trace_cma_alloc_start
Date: Tue, 19 Aug 2025 17:31:15 -0700 [thread overview]
Message-ID: <20250819173115.55194150617998021b4130b9@linux-foundation.org> (raw)
In-Reply-To: <20250819134817.247495-1-gxxa03070307@gmail.com>
On Tue, 19 Aug 2025 21:48:17 +0800 Xiang Gao <gxxa03070307@gmail.com> wrote:
> From: gaoxiang17 <gaoxiang17@xiaomi.com>
>
> This makes cma info more intuitive during debugging.
>
> ...
>
> --- a/include/trace/events/cma.h
> +++ b/include/trace/events/cma.h
>
> ...
>
> TP_STRUCT__entry(
> __string(name, name)
> - __field(unsigned long, count)
> + __field(unsigned long, request_count)
> + __field(unsigned long, available_count)
> + __field(unsigned long, total_count)
> __field(unsigned int, align)
> ),
>
> TP_fast_assign(
> __assign_str(name);
> - __entry->count = count;
> + __entry->count = request_count;
> + __entry->available_count = available_count;
> + __entry->total_count = total_count;
> __entry->align = align;
> ),
>
> TP_printk("name=%s count=%lu align=%u",
> __get_str(name),
> - __entry->count,
> + __entry->request_count,
> + __entry->available_count,
> + __entry->total_count,
> __entry->align)
adds three args to the printk but didn't add their conversions to the
printk control string?
prev parent reply other threads:[~2025-08-20 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 13:48 Xiang Gao
2025-08-19 19:17 ` David Hildenbrand
2025-08-20 0:31 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819173115.55194150617998021b4130b9@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=david@redhat.com \
--cc=gaoxiang17@xiaomi.com \
--cc=gxxa03070307@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®