From: Sebastian Reichel <sre@kernel.org>
To: Hans de Goede <hansg@kernel.org>,
Bryan O'Donoghue <bod@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Heimir Thor Sverrisson <heimir.sverrisson@gmail.com>,
Hans Verkuil <hverkuil@kernel.org>
Cc: Frederic Stuyk <fstuyk@runbox.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Sebastian Reichel <sre@kernel.org>
Subject: [PATCH 1/2] media: ov02c10: Fix default vertical flip
Date: Wed, 20 Aug 2025 02:13:19 +0200 [thread overview]
Message-ID: <20250820-ov02c10-fix-v1-1-3fcca2cfbfbf@kernel.org> (raw)
In-Reply-To: <20250820-ov02c10-fix-v1-0-3fcca2cfbfbf@kernel.org>
The driver right now defaults to setting the vertical flip bit. This
conflicts with proper handling of the rotation property defined in
ACPI or device tree, so drop the VFLIP bit. It should be handled via
V4L2_CID_VFLIP instead.
Reported-by: Frederic Stuyk <fstuyk@runbox.com>
Closes: https://lore.kernel.org/all/b6df9ae7-ea9f-4e5a-8065-5b130f534f37@runbox.com/
Fixes: 44f89010dae0 ("media: i2c: Add Omnivision OV02C10 sensor driver")
Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
drivers/media/i2c/ov02c10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov02c10.c b/drivers/media/i2c/ov02c10.c
index 089a4fd9627cf6c13efa65c104caeac370b53bc0..3a02fce0a9bc0ca3ab87defe3eefd04efb4012e7 100644
--- a/drivers/media/i2c/ov02c10.c
+++ b/drivers/media/i2c/ov02c10.c
@@ -175,7 +175,7 @@ static const struct reg_sequence sensor_1928x1092_30fps_setting[] = {
{0x3816, 0x01},
{0x3817, 0x01},
- {0x3820, 0xb0},
+ {0x3820, 0xa0},
{0x3821, 0x00},
{0x3822, 0x80},
{0x3823, 0x08},
--
2.50.1
next prev parent reply other threads:[~2025-08-20 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 0:13 [PATCH 0/2] media: ov02c10: fix orientation on Thinkpad T14s Gen6 (Snapdragon) Sebastian Reichel
2025-08-20 0:13 ` Sebastian Reichel [this message]
2025-08-21 8:31 ` [PATCH 1/2] media: ov02c10: Fix default vertical flip Bryan O'Donoghue
2025-08-20 0:13 ` [PATCH 2/2] media: ov02c10: Support hflip and vflip Sebastian Reichel
2025-08-21 8:33 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820-ov02c10-fix-v1-1-3fcca2cfbfbf@kernel.org \
--to=sre@kernel.org \
--cc=bod@kernel.org \
--cc=fstuyk@runbox.com \
--cc=hansg@kernel.org \
--cc=heimir.sverrisson@gmail.com \
--cc=hverkuil@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®