From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Liao Yuanhong <liaoyuanhong@vivo.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Petr Mladek <pmladek@suse.com>, Harry Yoo <harry.yoo@oracle.com>,
Kees Cook <kees@kernel.org>,
Sergio Perez Gonzalez <sperezglz@gmail.com>,
Miguel Ojeda <ojeda@kernel.org>,
Alice Ryhl <aliceryhl@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib/vsprintf: remove redundant header files
Date: Wed, 20 Aug 2025 11:36:27 +1000 [thread overview]
Message-ID: <20250820113627.5779ee46@canb.auug.org.au> (raw)
In-Reply-To: <CANiq72nNnz5esQpGFsENUm4cgGOAkkkqCuHyNxfEPHUrFvaH8g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 869 bytes --]
Hi all,
On Tue, 19 Aug 2025 15:37:20 +0200 Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Aug 19, 2025 at 3:13 PM Liao Yuanhong <liaoyuanhong@vivo.com> wrote:
> >
> > The header file <linux/stdarg.h> is already included on line 6. Remove the
> > redundant include.
> >
> > Fixes: 0dec7201788b9 ("sprintf.h requires stdarg.h")
>
> I don't think this fixes that commit -- `stdarg.h` was not there back then.
>
> Instead, this commit
>
> be06b53d3af0 ("lib/vsprintf: include stdarg.h from sprintf.h to
> provide va_list")
>
> also added the line, and I assume Stephen only needs to drop one of
> the lines in this merge resolution next time:
>
> 3f413b9a3770 ("Merge branch 'next' of
> https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git")
I have done that today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-08-20 1:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 13:13 Liao Yuanhong
2025-08-19 13:37 ` Miguel Ojeda
2025-08-19 14:18 ` Liao Yuanhong
2025-08-19 14:40 ` Miguel Ojeda
2025-08-20 1:36 ` Stephen Rothwell [this message]
2025-08-19 15:38 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820113627.5779ee46@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=aliceryhl@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=harry.yoo@oracle.com \
--cc=kees@kernel.org \
--cc=liaoyuanhong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=pmladek@suse.com \
--cc=sperezglz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®