From: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
To: Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Matt Wu <wuqiang.matt@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jan Kiszka <jan.kiszka@siemens.com>,
Kieran Bingham <kbingham@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
linux-media@vger.kernel.org,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>
Subject: [PATCH v2 7/9] hrtimer: Use hrtimer_cb_get_time() helper
Date: Thu, 21 Aug 2025 15:28:14 +0200 [thread overview]
Message-ID: <20250821-hrtimer-cleanup-get_time-v2-7-3ae822e5bfbd@linutronix.de> (raw)
In-Reply-To: <20250821-hrtimer-cleanup-get_time-v2-0-3ae822e5bfbd@linutronix.de>
Various other helpers contain open-coded implementations of
hrtimer_cb_get_time(). This prevents refactoring the implementation.
Reuse the existing helper.
For this to work, move hrtimer_cb_get_time() a bit up in the file and also
make its argument 'const'.
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
include/linux/hrtimer.h | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/include/linux/hrtimer.h b/include/linux/hrtimer.h
index 1ef867bb8c44b06812d8552441d4092922bfe170..e655502b14e6c4b1a69b67c997132d628bd1470f 100644
--- a/include/linux/hrtimer.h
+++ b/include/linux/hrtimer.h
@@ -154,14 +154,14 @@ static inline s64 hrtimer_get_expires_ns(const struct hrtimer *timer)
return ktime_to_ns(timer->node.expires);
}
-static inline ktime_t hrtimer_expires_remaining(const struct hrtimer *timer)
+static inline ktime_t hrtimer_cb_get_time(const struct hrtimer *timer)
{
- return ktime_sub(timer->node.expires, timer->base->get_time());
+ return timer->base->get_time();
}
-static inline ktime_t hrtimer_cb_get_time(struct hrtimer *timer)
+static inline ktime_t hrtimer_expires_remaining(const struct hrtimer *timer)
{
- return timer->base->get_time();
+ return ktime_sub(timer->node.expires, hrtimer_cb_get_time(timer));
}
static inline int hrtimer_is_hres_active(struct hrtimer *timer)
@@ -200,8 +200,7 @@ __hrtimer_expires_remaining_adjusted(const struct hrtimer *timer, ktime_t now)
static inline ktime_t
hrtimer_expires_remaining_adjusted(const struct hrtimer *timer)
{
- return __hrtimer_expires_remaining_adjusted(timer,
- timer->base->get_time());
+ return __hrtimer_expires_remaining_adjusted(timer, hrtimer_cb_get_time(timer));
}
#ifdef CONFIG_TIMERFD
@@ -363,7 +362,7 @@ hrtimer_forward(struct hrtimer *timer, ktime_t now, ktime_t interval);
static inline u64 hrtimer_forward_now(struct hrtimer *timer,
ktime_t interval)
{
- return hrtimer_forward(timer, timer->base->get_time(), interval);
+ return hrtimer_forward(timer, hrtimer_cb_get_time(timer), interval);
}
/* Precise sleep: */
--
2.50.1
next prev parent reply other threads:[~2025-08-21 13:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 13:28 [PATCH v2 0/9] hrtimer: Remove hrtimer_clock_base::get_time Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 1/9] posix-timers: Avoid direct access to hrtimer clockbase Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 2/9] timers/itimer: " Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 3/9] sched/core: " Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 4/9] lib: test_objpool: " Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 5/9] ALSA: hrtimer: " Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 6/9] media: pwm-ir-tx: " Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` Thomas Weißschuh [this message]
2025-09-09 10:31 ` [tip: timers/core] hrtimer: Use hrtimer_cb_get_time() helper tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 8/9] hrtimer: Remove hrtimer_clock_base::get_time Thomas Weißschuh
2025-09-09 10:31 ` [tip: timers/core] hrtimer: Remove hrtimer_clock_base:: Get_time tip-bot2 for Thomas Weißschuh
2025-08-21 13:28 ` [PATCH v2 9/9] hrtimer: Reorder branches in hrtimer_clockid_to_base() Thomas Weißschuh
2025-09-09 10:30 ` [tip: timers/core] " tip-bot2 for Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821-hrtimer-cleanup-get_time-v2-7-3ae822e5bfbd@linutronix.de \
--to=thomas.weissschuh@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=juri.lelli@redhat.com \
--cc=kbingham@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sean@mess.org \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=wuqiang.matt@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®