mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bala-Vignesh-Reddy <reddybalavignesh9979@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, reddybalavignesh9979@gmail.com,
	rppt@kernel.org, shuah@kernel.org, skhan@linuxfoundation.org,
	surenb@google.com
Subject: Re: [PATCH] selftests: proc: mark vsyscall strings maybe-unused
Date: Thu, 21 Aug 2025 16:01:39 +0530	[thread overview]
Message-ID: <20250821103139.2872-1-reddybalavignesh9979@gmail.com> (raw)
In-Reply-To: <20250820143954.33d95635e504e94df01930d0@linux-foundation.org>

Hi Andrew,

Thanks for your feedback, I didn't notice that __maybe_unused is
defined repeatedly in selftests directory.

Following your suggestions, I've submitted a cleanup patch that centralise
the __maybe_unused definition in tools/testing/selftests/kselftest.h and
removed the redundant copies across the selftests subdirectories.
I've tested it with gcc and clang, and it builds cleanly.

Patch Link:
https://lore.kernel.org/lkml/20250821101159.2238-1-reddybalavignesh9979@gmail.com/

Will also look into build system, to tackle including kselftest.h everywhere

Thanks,
Bala Vignesh

      reply	other threads:[~2025-08-21 10:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20 17:56 Bala-Vignesh-Reddy
2025-08-20 21:39 ` Andrew Morton
2025-08-21 10:31   ` Bala-Vignesh-Reddy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250821103139.2872-1-reddybalavignesh9979@gmail.com \
    --to=reddybalavignesh9979@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=rppt@kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®