From: Osama Abdelkader <osama.abdelkader@gmail.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
ilpo.jarvinen@linux.intel.com, mingo@kernel.org,
john.ogness@linutronix.de, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Osama Abdelkader <osama.abdelkader@gmail.com>
Subject: [PATCH] serial: 8250_core: fix coding style issues
Date: Thu, 21 Aug 2025 19:58:56 +0200 [thread overview]
Message-ID: <20250821175856.22957-1-osama.abdelkader@gmail.com> (raw)
Fix a few coding style issues in 8250_core.c:
- Remove redundant NULL initialization of a global pointer
- Add missing blank line after a variable declaration
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
drivers/tty/serial/8250/8250_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index feb920c5b2e8..0d1d2eed2a5c 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -307,7 +307,7 @@ static void univ8250_release_irq(struct uart_8250_port *up)
serial_unlink_irq_chain(up);
}
-const struct uart_ops *univ8250_port_base_ops = NULL;
+const struct uart_ops *univ8250_port_base_ops;
struct uart_ops univ8250_port_ops;
static const struct uart_8250_ops univ8250_driver_ops = {
@@ -773,6 +773,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up)
*/
if (!has_acpi_companion(uart->port.dev)) {
struct mctrl_gpios *gpios = mctrl_gpio_init(&uart->port, 0);
+
if (IS_ERR(gpios)) {
ret = PTR_ERR(gpios);
goto err;
--
2.43.0
next reply other threads:[~2025-08-21 17:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 17:58 Osama Abdelkader [this message]
2025-08-21 18:03 ` Greg KH
2025-08-22 4:30 ` Jiri Slaby
2025-08-22 8:10 ` Osama Abdelkader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821175856.22957-1-osama.abdelkader@gmail.com \
--to=osama.abdelkader@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®