From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76229393DC3 for ; Thu, 21 Aug 2025 21:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755812192; cv=none; b=ioyGJSwzwWu3QYzqD2VLSmu05y072oekFbWqjYfsogBBcYwBdqIj9qobzutwObRn5aOf86yjv/FCGEGasM+indBTnBZnzaCdIw247T/ya1dSWIZK3iU/VMelL8jx3VIsGq1YcgKX8dQx30Omlqgcx/gH980XFBgVwWgweyl7fDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755812192; c=relaxed/simple; bh=0ZrNqJZT2DaYZRgAJFFOa0xEYOpeRsDeFYBL6NuqxbU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=BxfmP1Iu6fGicdfgdGdlV/SyjoSbFl2KAGwEI/2hkS0DcYg6hsKCrMaIx2xxDwJzbuhHKQ5Z6zbxl44rTWQ4/6BPVsfEZnB2T7hcPvLADvAvel2MytSGMHBY//FcmgzlKlRaDz5NvSzndzbCdiWO9CDeFjtay/ZlCausmwq7IdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OA5Y7U67; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OA5Y7U67" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2174C4CEEB; Thu, 21 Aug 2025 21:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755812192; bh=0ZrNqJZT2DaYZRgAJFFOa0xEYOpeRsDeFYBL6NuqxbU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OA5Y7U673iMYZhUvNnMwFvQkUXKn9V2phc6Jy4na7rPmNy5W3Cb2nWXmb48SIC4/R 58wj17tMqHDq8VqLwvpKsRy940cBsvi96EJ+Z0VV8m9eiykR/GEkkbVXNgSRhhDgjf esn/3gfCBl+giswZXHMhbrsiqEykeIdeLApqKrysRKVEBspeqtWcl3m19sqw+f9VZm zDW8xM76bYQgSwop1GDGxe0VZRpOeZM6xO7ZBUY8RUuBFti0WPTgr4aPz5ik2TM4gS Qakin0sXw1RQISlrvvR1RQiDME2JWDB2CvkXdF49ZbtSEfLQBg/j1yiId9nPVEetyI fjIUeT8fWu7Hw== From: SeongJae Park To: Chris Li Cc: SeongJae Park , Barry Song <21cnbao@gmail.com>, Nhat Pham , Herbert Xu , Andrew Morton , Chengming Zhou , Johannes Weiner , Yosry Ahmed , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Takero Funaki , David Hildenbrand , Baoquan He , Kairui Song Subject: Re: [PATCH v4] mm/zswap: store X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Thu, 21 Aug 2025 13:49:31 -0700 Chris Li wrote: > On Thu, Aug 21, 2025 at 9:43 AM SeongJae Park wrote: > > > > On Thu, 21 Aug 2025 18:27:52 +0800 Barry Song <21cnbao@gmail.com> wrote: > > > > > On Thu, Aug 21, 2025 at 1:33 AM Nhat Pham wrote: > > > > > > > > On Tue, Aug 19, 2025 at 6:37 PM Herbert Xu wrote: > > > > > > > > > > On Wed, Aug 20, 2025 at 01:34:01PM +1200, Barry Song wrote: > > > > > > > > > > > > We might want to revisit the old thread to check whether it is now safe for us > > > > > > to move to PAGE_SIZE in zswap now. > > > > > > > > > > It's perfectly safe as LZO was fixed months ago. > > > > > > > > Perfect. Then I'll revive Chengming's patch (see [1]) to reduce the > > > > compression buffer :) > > > > > > Nice! > > > > > > But perhaps we should wait until SeongJae sends a new version that > > > addresses the counter issue? > > > > Is there a reason to wait? I was thinking those are orthogonal problems? > > > > Anyway, for the counter (crypto_compress_fail), I don't have a strong opinion. > > To my understanding, the options for path forward are... > > > > 1. remove it, > > 2. keep it as is, or > > 3. keep it, but account only -EINPROGRESS[1] > > > > If I'm not missing other options, I'm tempted to the first option (remove it) > > since it doesn't change any existing things, and we can revisit later. > > I am fine with 1) removing it. Maybe add a log once print error on the > error code if -EINPROGRESS, just to know such extreme error has been > triggered. > > > > Please let me know if I'm missing other options or if you have other preferences. > > I just don't want to hide the extreme error case but I am also fine > with just removing it. It is your call. Thank you for your opinion, Chris! Unless others have different opinions, I will only remove the counter (option 1), since it is simplest and we can consider adding another counter or error logs on top of it. Thanks, SJ [...]