From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFAF52F49E4 for ; Fri, 22 Aug 2025 10:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755858619; cv=none; b=PujFJ6ggdDlhcI2emkekWyLkAILNXFoqZb4OpOEcyz4WBbyY2vRCGiDozUytzuFyjBBfVap65TWf84/kisS5y216tG8a4dWIxl4y556hBBmPzkS+4yNGNjWEUCt6ooHrdb426Ux/+i5ypB5dJvnnfsBZdqwTUL/16z33bT6bZzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755858619; c=relaxed/simple; bh=N2MIGbNyxlDN+r9SnBla5fY5nVigW9XgjuVc2XXDEzc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r1tpi7eOdt3QYe6rnF2A79xbXEwFNdVD9XLCAukoTeMgmAH5NDt0Ned0X//QMt+sKtxOuzsnsE93XSCL7ZIYg7C4HfOoJvcQZntyovSmkAN+ZZVzqygRIjH3myrre5aWi96di7pLxzTUwLKTcrmCXnC6U+ig0SLVTpMhbPg8Lc4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1upP26-0006C3-2R; Fri, 22 Aug 2025 12:30:06 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1upP25-001Ysi-2H; Fri, 22 Aug 2025 12:30:05 +0200 Received: from mfe by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1upP25-00A6R0-1o; Fri, 22 Aug 2025 12:30:05 +0200 Date: Fri, 22 Aug 2025 12:30:05 +0200 From: Marco Felsch To: Krzysztof Kozlowski Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Fabio Estevam , Matthias Kaehlcke , Liam Girdwood , Mark Brown , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v3 3/4] dt-bindings: usb: microchip,usb2514: add support for port vbus-supply Message-ID: <20250822103005.c7ba7dclbgdadyw7@pengutronix.de> References: <20250821-v6-16-topic-usb-onboard-dev-v3-0-6d2b38a5d818@pengutronix.de> <20250821-v6-16-topic-usb-onboard-dev-v3-3-6d2b38a5d818@pengutronix.de> <20250822-maize-elk-of-growth-2a30bb@kuoka> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250822-maize-elk-of-growth-2a30bb@kuoka> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On 25-08-22, Krzysztof Kozlowski wrote: > On Thu, Aug 21, 2025 at 06:31:57PM +0200, Marco Felsch wrote: > > Some PCB designs don't connect the USB hub port power control GPIO and > > instead make use of a host controllable regulator. Add support for this > > use-case by introducing portX-vbus-supply property. > > > > Signed-off-by: Marco Felsch > > --- > > Documentation/devicetree/bindings/usb/microchip,usb2514.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > > index 4e3901efed3fcd4fbbd8cb777f9df4fcadf2ca00..ac1e5f1a5ea2e66c61ce92154385952b15e78e55 100644 > > --- a/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > > +++ b/Documentation/devicetree/bindings/usb/microchip,usb2514.yaml > > @@ -49,6 +49,12 @@ patternProperties: > > $ref: /schemas/usb/usb-device.yaml > > additionalProperties: true > > > > + "^port[1-7]-vbus-supply$": > > + type: object > > + description: > > + Regulator controlling the USB VBUS on portX. Only required if the host > > + controls the portX VBUS. > > Your commit msg should briefly describe status of previous discussion: > why Rob's comment was not applied. Otherwise we repeat: this looks like > property of specific port. I answered Rob on my v1 but got no feedback. My v2 caused an issue found by Rob's test bot. Therefore I thought he is okay and applied the patchset for testing. At least to me it's unclear when Rob's test bot is executed. > The binding does not list ports now, but lists hard-wired devices, so my > question is now: is this per hard-wired device or per port (even if port > is hot-pluggable)? Sorry but I don't get you. The binding lists the regulators required to enable/disable the hub downstream port VBUS. These regulators are controlled by an external party e.g. the CPU instead of the USB hub itself. The connection from the CPU to the regulator which controlls the +5V usb-connector pin is hard-wired, yes. Regards, Marco