mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chenghai Huang <huangchenghai2@huawei.com>
To: <gregkh@linuxfoundation.org>, <zhangfei.gao@linaro.org>,
	<wangzhou1@hisilicon.com>
Cc: <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>,
	<linux-crypto@vger.kernel.org>, <fanghao11@huawei.com>,
	<shenyang39@huawei.com>, <qianweili@huawei.com>,
	<linwenkai6@hisilicon.com>, <liulongfang@huawei.com>
Subject: [PATCH 2/4] uacce: fix isolate sysfs check condition
Date: Fri, 22 Aug 2025 18:39:02 +0800	[thread overview]
Message-ID: <20250822103904.3776304-3-huangchenghai2@huawei.com> (raw)
In-Reply-To: <20250822103904.3776304-1-huangchenghai2@huawei.com>

The uacce supports device isolation feature. If the driver
implements the isolate_err_threshold_read and
isolate_err_threshold_write callbacks, the uacce will create sysfs
files. Users can read and configure isolation policies through
sysfs. Currently, if either isolate_err_threshold_read or
isolate_err_threshold_write callback exists, sysfs files are
created.

However, accessing a non-existent callback may cause a system panic.
Therefore, sysfs files are only created when both
isolate_err_threshold_read and isolate_err_threshold_write are
present.

Fixes: e3e289fbc0b5 ("uacce: supports device isolation feature")
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
---
 drivers/misc/uacce/uacce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
index 3604f722ed60..6a38809ca819 100644
--- a/drivers/misc/uacce/uacce.c
+++ b/drivers/misc/uacce/uacce.c
@@ -441,7 +441,7 @@ static umode_t uacce_dev_is_visible(struct kobject *kobj,
 		return 0;
 
 	if (attr == &dev_attr_isolate_strategy.attr &&
-	    (!uacce->ops->isolate_err_threshold_read &&
+	    (!uacce->ops->isolate_err_threshold_read ||
 	     !uacce->ops->isolate_err_threshold_write))
 		return 0;
 
-- 
2.33.0


  parent reply	other threads:[~2025-08-22 10:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 10:39 [PATCH 0/4] uacce: driver fixes for memory leaks and state management Chenghai Huang
2025-08-22 10:39 ` [PATCH 1/4] uacce: fix for cdev memory leak Chenghai Huang
2025-08-22 11:27   ` Greg KH
2025-09-13 10:43     ` huangchenghai
2025-08-25  8:20   ` Zhangfei Gao
2025-08-28 12:59     ` linwenkai (C)
2025-08-22 10:39 ` Chenghai Huang [this message]
2025-08-22 10:39 ` [PATCH 3/4] uacce: implement mremap in uacce_vm_ops to return -EPERM Chenghai Huang
2025-08-22 11:46   ` Greg KH
2025-08-28  5:59     ` Zhangfei Gao
2025-09-06 12:03       ` Greg KH
2025-09-08  6:33         ` Zhangfei Gao
2025-09-13 10:40         ` huangchenghai
2025-09-13 11:06           ` Greg KH
2025-09-15  1:48             ` huangchenghai
2025-08-22 10:39 ` [PATCH 4/4] uacce: ensure safe queue release with state management Chenghai Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250822103904.3776304-3-huangchenghai2@huawei.com \
    --to=huangchenghai2@huawei.com \
    --cc=fanghao11@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=linwenkai6@hisilicon.com \
    --cc=liulongfang@huawei.com \
    --cc=qianweili@huawei.com \
    --cc=shenyang39@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®