From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: geert@linux-m68k.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
linux-m68k@lists.linux-m68k.org
Subject: [PATCH] m68k: make HPDCA and HPAPCI bools
Date: Fri, 22 Aug 2025 12:42:08 +0200 [thread overview]
Message-ID: <20250822104208.751191-1-jirislaby@kernel.org> (raw)
The only user -- 8250_hp300 -- tests for CONFIG_HPDCA and CONFIG_HPAPCI.
It does not test for *_MODULE variants. That means that if someone sets
the configs to =m, the code is not compiled at all.
There is actually no point having these as tristate. Switch them to
bool.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
arch/m68k/Kconfig.devices | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/m68k/Kconfig.devices b/arch/m68k/Kconfig.devices
index e6e3efac1840..e277f1bd2de1 100644
--- a/arch/m68k/Kconfig.devices
+++ b/arch/m68k/Kconfig.devices
@@ -105,14 +105,14 @@ config AMIGA_BUILTIN_SERIAL
To compile this driver as a module, choose M here.
config HPDCA
- tristate "HP DCA serial support"
+ bool "HP DCA serial support"
depends on DIO && SERIAL_8250
help
If you want to use the internal "DCA" serial ports on an HP300
machine, say Y here.
config HPAPCI
- tristate "HP APCI serial support"
+ bool "HP APCI serial support"
depends on HP300 && SERIAL_8250
help
If you want to use the internal "APCI" serial ports on an HP400
--
2.51.0
next reply other threads:[~2025-08-22 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 10:42 Jiri Slaby (SUSE) [this message]
2025-09-01 8:53 ` Geert Uytterhoeven
2025-09-08 9:47 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822104208.751191-1-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®