mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herve Codina <herve.codina@bootlin.com>
To: Cryolitia PukNgae via B4 Relay
	<devnull+cryolitia.uniontech.com@kernel.org>
Cc: cryolitia@uniontech.com, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	guanwentao@uniontech.com, niecheng1@uniontech.com,
	zhanjun@uniontech.com
Subject: Re: [PATCH] ASoC: codecs: idt821034: fix wrong log in idt821034_chip_direction_output()
Date: Fri, 22 Aug 2025 12:40:36 +0200	[thread overview]
Message-ID: <20250822124036.2855a5f0@bootlin.com> (raw)
In-Reply-To: <20250822-idt821034-v1-1-e2bfffbde56f@uniontech.com>

Hi Cryolitia,

On Fri, 22 Aug 2025 18:28:33 +0800
Cryolitia PukNgae via B4 Relay <devnull+cryolitia.uniontech.com@kernel.org> wrote:

> From: Cryolitia PukNgae <cryolitia@uniontech.com>
> 
> Change `dir in` to `dir out`
> 
> Suggested-by: Jun Zhan <zhanjun@uniontech.com>
> Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
> ---
>  sound/soc/codecs/idt821034.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/idt821034.c b/sound/soc/codecs/idt821034.c
> index 6738cf21983b0dc58e162cbfaacaedb5edaaa245..a03d4e5e7d144195622ea0cbf6b6c6ba95642aa7 100644
> --- a/sound/soc/codecs/idt821034.c
> +++ b/sound/soc/codecs/idt821034.c
> @@ -1067,7 +1067,7 @@ static int idt821034_chip_direction_output(struct gpio_chip *c, unsigned int off
>  
>  	ret = idt821034_set_slic_conf(idt821034, ch, slic_conf);
>  	if (ret) {
> -		dev_err(&idt821034->spi->dev, "dir in gpio %d (%u, 0x%x) failed (%d)\n",
> +		dev_err(&idt821034->spi->dev, "dir out gpio %d (%u, 0x%x) failed (%d)\n",
>  			offset, ch, mask, ret);
>  	}
>  
> 
> ---
> base-commit: 3957a5720157264dcc41415fbec7c51c4000fc2d
> change-id: 20250822-idt821034-0b5cb86b0c96
> 

Thanks for the patch.

Acked-by: Herve Codina <herve.codina@bootlin.com>

Best regards,
Hervé

  reply	other threads:[~2025-08-22 10:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 10:28 Cryolitia PukNgae via B4 Relay
2025-08-22 10:40 ` Herve Codina [this message]
2025-08-25 20:04 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250822124036.2855a5f0@bootlin.com \
    --to=herve.codina@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=cryolitia@uniontech.com \
    --cc=devnull+cryolitia.uniontech.com@kernel.org \
    --cc=guanwentao@uniontech.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=niecheng1@uniontech.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®