From: Borislav Petkov <bp@alien8.de>
To: darshanrathod475@gmail.com
Cc: tony.luck@intel.com, james.morse@arm.com, mchehab@kernel.org,
rric@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] edac/amd76x: Remove assignment from if condition in amd76x_remove_one()
Date: Fri, 22 Aug 2025 16:48:19 +0200 [thread overview]
Message-ID: <20250822144819.GAaKiDM8l-eJgU1-bs@fat_crate.local> (raw)
In-Reply-To: <20250812130154.2220684-1-darshanrathod475@gmail.com>
On Tue, Aug 12, 2025 at 06:31:54PM +0530, darshanrathod475@gmail.com wrote:
> From: Darshan Rathod <darshanrathod475@gmail.com>
>
> The code was performing an assignment inside the if condition:
>
> if ((mci = edac_mc_del_mc(&pdev->dev)) == NULL)
>
> This triggers a checkpatch.pl warning.
And?
Is this a bug or just something some silly script is telling you to do?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2025-08-22 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 13:01 darshanrathod475
2025-08-22 14:48 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822144819.GAaKiDM8l-eJgU1-bs@fat_crate.local \
--to=bp@alien8.de \
--cc=darshanrathod475@gmail.com \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rric@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®