From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F04BB280335 for ; Fri, 22 Aug 2025 16:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755881062; cv=none; b=LAHG5xa42oMMlynizKw/uP1k6MOXz498tivbPZ/oOUzBtJI9VAt8riTWgq6GUlKRjAFCzOm392bVUyYMKQsyT2wX33F2s/3eFuiJwTfOlmjBznIq+d28ijsOBy1WydLOYolXNIgPm7QirzrRSSpvYNTLRnGilmnnG/LeCdBJemM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755881062; c=relaxed/simple; bh=k1cK3Xue+HD3m7URxYZ8fT3eh0OpuLIIwinvJH3zioM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=tYJE6D5cFpXdgX7moEsjXZCk9DSre8jLem74yUJH7Ql4TMFGQf3FUNH0q2SGYciIRbvB5mbArUTbeH6S2tSYbj6ONAVPsI1dH5hhL6qWyFDsorS/oimMd7/SLkFs7M9qQ7rJ2tDO3AlIxcbufkoiDyfpJtoPp0QtGmoefUlZsXI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Juqfm1fJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Juqfm1fJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4328AC4CEED; Fri, 22 Aug 2025 16:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755881058; bh=k1cK3Xue+HD3m7URxYZ8fT3eh0OpuLIIwinvJH3zioM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Juqfm1fJRNO3ABVAETXZytIvmf535GRaCb+cbkSlgeNhd9xtSDNs+2dBL7vSGlB02 1Z9zIhoBqW7uG9ep8bRXLd/57/FlY8gxMG1/lSKs6/k7IW5PgHx0Gy/av57PE5DZPa vbQdOIYRZvkkLiHn4wUZRfdNfiSfkFa9kzPQzT3l+RXnRoWXUAeK4ei9JgqumMJqtV 6H0olStRqs5gvsaxkNEKQ5OHDjPqTbd3F41Nuow1w9cZupyss27jLPXiUxQ3ywWs5e Yq4LgEbhEWXZ1MGtWMVpF3qG8ZeP4wBwwxzU8TzgZ9qIRnqyJYCwh8JuYINrWbhODA t+rqQa32fN/VQ== From: SeongJae Park To: Barry Song <21cnbao@gmail.com> Cc: SeongJae Park , Herbert Xu , Chris Li , Nhat Pham , Andrew Morton , Chengming Zhou , Johannes Weiner , Yosry Ahmed , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Takero Funaki , David Hildenbrand , Baoquan He , Kairui Song Subject: Re: [PATCH v4] mm/zswap: store X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Fri, 22 Aug 2025 12:48:27 +1200 Barry Song <21cnbao@gmail.com> wrote: > > > > > > > > 1. remove it, > > > > 2. keep it as is, or > > > > 3. keep it, but account only -EINPROGRESS[1] > > > > > > > > If I'm not missing other options, I'm tempted to the first option (remove it) > > > > since it doesn't change any existing things, and we can revisit later. > > > > > > I am fine with 1) removing it. Maybe add a log once print error on the > > > error code if -EINPROGRESS, just to know such extreme error has been > > > triggered. > > > > > > > > Please let me know if I'm missing other options or if you have other preferences. > > > > > > I just don't want to hide the extreme error case but I am also fine > > > with just removing it. It is your call. > > > > Thank you for your opinion, Chris! Unless others have different opinions, I > > will only remove the counter (option 1), since it is simplest and we can > > consider adding another counter or error logs on top of it. > > Yes, that seems the best option—to remove the counter for now. Thank you for making your opinion clear, Barry. I will post v5 soon. Thanks, SJ [...]