Re: [PATCH v2 03/16] Introduce wake_up_key()

[kernel test robot <lkp@intel.com>]

Hi NeilBrown,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on trondmy-nfs/linux-next linus/master v6.17-rc2 next-20250822]
[cannot apply to tip/sched/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/NeilBrown/VFS-discard-err2-in-filename_create/20250822-081444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20250822000818.1086550-4-neil%40brown.name
patch subject: [PATCH v2 03/16] Introduce wake_up_key()
config: sh-randconfig-r073-20250822 (https://download.01.org/0day-ci/archive/20250822/202508222051.JpjiLYJb-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 10.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250822/202508222051.JpjiLYJb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508222051.JpjiLYJb-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpio/gpiolib-cdev.c: In function 'linereq_put_event':
>> drivers/gpio/gpiolib-cdev.c:596:2: error: 'else' without a previous 'if'
     596 |  else
         |  ^~~~
   drivers/gpio/gpiolib-cdev.c: In function 'lineevent_irq_thread':
   drivers/gpio/gpiolib-cdev.c:2018:2: error: 'else' without a previous 'if'
    2018 |  else
         |  ^~~~
   drivers/gpio/gpiolib-cdev.c: In function 'lineinfo_changed_func':
   drivers/gpio/gpiolib-cdev.c:2536:2: error: 'else' without a previous 'if'
    2536 |  else
         |  ^~~~


vim +596 drivers/gpio/gpiolib-cdev.c

a0dda508bd66b9e Bartosz Golaszewski 2023-08-17  581  
73e0341992b68bb Kent Gibson         2020-09-28  582  static void linereq_put_event(struct linereq *lr,
73e0341992b68bb Kent Gibson         2020-09-28  583  			      struct gpio_v2_line_event *le)
73e0341992b68bb Kent Gibson         2020-09-28  584  {
73e0341992b68bb Kent Gibson         2020-09-28  585  	bool overflow = false;
73e0341992b68bb Kent Gibson         2020-09-28  586  
0ebeaab4d59eb37 Kent Gibson         2023-12-19  587  	scoped_guard(spinlock, &lr->wait.lock) {
73e0341992b68bb Kent Gibson         2020-09-28  588  		if (kfifo_is_full(&lr->events)) {
73e0341992b68bb Kent Gibson         2020-09-28  589  			overflow = true;
73e0341992b68bb Kent Gibson         2020-09-28  590  			kfifo_skip(&lr->events);
73e0341992b68bb Kent Gibson         2020-09-28  591  		}
73e0341992b68bb Kent Gibson         2020-09-28  592  		kfifo_in(&lr->events, le, 1);
0ebeaab4d59eb37 Kent Gibson         2023-12-19  593  	}
73e0341992b68bb Kent Gibson         2020-09-28  594  	if (!overflow)
73e0341992b68bb Kent Gibson         2020-09-28  595  		wake_up_poll(&lr->wait, EPOLLIN);
73e0341992b68bb Kent Gibson         2020-09-28 @596  	else
73e0341992b68bb Kent Gibson         2020-09-28  597  		pr_debug_ratelimited("event FIFO is full - event dropped\n");
73e0341992b68bb Kent Gibson         2020-09-28  598  }
73e0341992b68bb Kent Gibson         2020-09-28  599  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki