mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maud Spierings via B4 Relay <devnull+maud_spierings.hotmail.com@kernel.org>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,  Ondrej Jirman <megi@xff.cz>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-rockchip@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	 Maud Spierings <maud_spierings@hotmail.com>
Subject: [PATCH 1/3] arm64: dts: rockchip: Fix the headphone detection on the orangepi 5 plus
Date: Sat, 23 Aug 2025 14:43:50 +0200	[thread overview]
Message-ID: <20250823-orangepi5-v1-1-ae77dd0e06d7@hotmail.com> (raw)
In-Reply-To: <20250823-orangepi5-v1-0-ae77dd0e06d7@hotmail.com>

From: Maud Spierings <maud_spierings@hotmail.com>

The logic of the headphone detect pin seems to be inverted, with this
change headphones actually output sound when plugged in.

Verified by checking /sys/kernel/debug/gpio and by listening.

Fixes: 236d225e1ee7 ("arm64: dts: rockchip: Add board device tree for rk3588-orangepi-5-plus")
Signed-off-by: Maud Spierings <maud_spierings@hotmail.com>
---
There was a big change at some point so it will take some effor to port
it back that far.
---
 arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
index 121e4d1c3fa5dab0d08edf7cba692a765b48f7b4..8222f1fae8fadc5cbb4ef16b3db5ed975ed43915 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts
@@ -77,7 +77,7 @@ &analog_sound {
 	pinctrl-names = "default";
 	pinctrl-0 = <&hp_detect>;
 	simple-audio-card,aux-devs = <&speaker_amp>, <&headphone_amp>;
-	simple-audio-card,hp-det-gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_LOW>;
+	simple-audio-card,hp-det-gpios = <&gpio1 RK_PD3 GPIO_ACTIVE_HIGH>;
 	simple-audio-card,widgets =
 		"Microphone", "Onboard Microphone",
 		"Microphone", "Microphone Jack",

-- 
2.50.1



  reply	other threads:[~2025-08-23 12:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-23 12:43 [PATCH 0/3] arm64: dts: rockchip: Improvements for rk3588-orangepi-5 and friends Maud Spierings via B4 Relay
2025-08-23 12:43 ` Maud Spierings via B4 Relay [this message]
2025-08-23 13:31   ` [PATCH 1/3] arm64: dts: rockchip: Fix the headphone detection on the orangepi 5 plus Ondřej Jirman
2025-08-23 12:43 ` [PATCH 2/3] arm64: dts: rockchip: Enable HDMI receiver on " Maud Spierings via B4 Relay
2025-08-23 14:23   ` Ondřej Jirman
2025-08-23 12:43 ` [PATCH 3/3] arm64: dts: rockchip: Enable the NPU on the orangepi 5 boards Maud Spierings via B4 Relay
2025-08-23 14:21   ` Ondřej Jirman
2025-08-24  7:07 ` [PATCH 0/3] arm64: dts: rockchip: Improvements for rk3588-orangepi-5 and friends Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250823-orangepi5-v1-1-ae77dd0e06d7@hotmail.com \
    --to=devnull+maud_spierings.hotmail.com@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maud_spierings@hotmail.com \
    --cc=megi@xff.cz \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®