From: Alex Robinson <alex@ironrobin.net>
To: robin.clark@oss.qualcomm.com
Cc: lumag@kernel.org, abhinav.kumar@linux.dev,
jessica.zhang@oss.qualcomm.com, sean@poorly.run,
marijn.suijten@somainline.org, airlied@gmail.com,
simona@ffwll.ch, linux-arm-msm@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-kernel@vger.kernel.org, Alex Robinson <alex@ironrobin.net>
Subject: [PATCH] drm/msm: fix race in Adreno header generation
Date: Sat, 23 Aug 2025 02:09:39 +0000 [thread overview]
Message-ID: <20250823020919.9947-1-alex@ironrobin.net> (raw)
Builds can compile msm-y objects (e.g. msm_gpu_devfreq.o)
before adreno_common.xml.h is generated in trees that generate Adreno
headers at build time. Make msm-y depend on the generated headers,
removing the race.
Signed-off-by: Alex Robinson <alex@ironrobin.net>
---
drivers/gpu/drm/msm/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile
index 0c0dfb25f01b..1a918d44ac48 100644
--- a/drivers/gpu/drm/msm/Makefile
+++ b/drivers/gpu/drm/msm/Makefile
@@ -221,6 +221,7 @@ DISPLAY_HEADERS = \
generated/sfpb.xml.h
$(addprefix $(obj)/,$(adreno-y)): $(addprefix $(obj)/,$(ADRENO_HEADERS))
+$(addprefix $(obj)/,$(msm-y)): $(addprefix $(obj)/,$(ADRENO_HEADERS))
$(addprefix $(obj)/,$(msm-display-y)): $(addprefix $(obj)/,$(DISPLAY_HEADERS))
targets += $(ADRENO_HEADERS) $(DISPLAY_HEADERS)
--
2.50.1
next reply other threads:[~2025-08-23 2:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 2:09 Alex Robinson [this message]
2025-08-23 2:19 ` Rob Clark
2025-08-23 13:49 ` Dmitry Baryshkov
2025-08-23 14:16 ` Rob Clark
2025-08-25 16:23 ` Akhil P Oommen
2025-08-25 17:48 ` Rob Clark
2025-08-25 19:59 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250823020919.9947-1-alex@ironrobin.net \
--to=alex@ironrobin.net \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jessica.zhang@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®