mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Junjie Cao <junjie.cao@intel.com>,
	linux-iio@vger.kernel.org, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: core: switch info_mask fields to unsigned long to match find_bit helpers
Date: Mon, 25 Aug 2025 11:08:12 +0100	[thread overview]
Message-ID: <20250825110812.63c276c5@jic23-huawei> (raw)
In-Reply-To: <CAHp75Vc_GYzDw77deKjK5Pn9duGi0p8W4C2Z9kmVWBWK5qgETg@mail.gmail.com>

On Wed, 20 Aug 2025 12:52:18 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Wed, Aug 20, 2025 at 3:48 AM Junjie Cao <junjie.cao@intel.com> wrote:
> >
> > for_each_set_bit()/find_*_bit() expect arrays of unsigned long (see
> > include/linux/find.h), but industrialio-core passed const long * into
> > iio_device_add_info_mask_type{,_avail}().
> >
> > These masks are used purely as bit arrays and are populated via BIT()
> > (1UL << n). Switch the info_mask_* fields and the corresponding function
> > parameters to unsigned long so the types match the helpers. This removes
> > sparse warnings about signedness mismatches (seen with 'make C=1'
> > CF='-Wsparse-all') without changing behavior or struct layout.
> >
> > No functional change intended.  
> 
> Thanks, this is better than v1.
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
> 

Applied.

Thanks,

Jonathan

      reply	other threads:[~2025-08-25 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-20  0:47 Junjie Cao
2025-08-20  9:52 ` Andy Shevchenko
2025-08-25 10:08   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825110812.63c276c5@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=junjie.cao@intel.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®