From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Xu Liang <lxu@maxlinear.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] net: phy: mxl-86110: add basic support for led_brightness_set op
Date: Mon, 25 Aug 2025 17:10:51 -0700 [thread overview]
Message-ID: <20250825171051.1fd1806d@kernel.org> (raw)
In-Reply-To: <58eeefc8c24e06cd2110d3cefbd4236b1a4f44a2.1755884175.git.daniel@makrotopia.org>
On Fri, 22 Aug 2025 18:38:27 +0100 Daniel Golle wrote:
> +static int mxl86110_modify_extended_reg(struct phy_device *phydev,
> + u16 regnum, u16 mask, u16 set)
For the future patches -- the names of register write helpers are
unnecessarily long in this driver. They make us go over 80 chars
for no good reason.
next prev parent reply other threads:[~2025-08-26 0:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 17:38 Daniel Golle
2025-08-22 17:38 ` [PATCH v4 2/3] net: phy: mxl-86110: fix indentation in struct phy_driver Daniel Golle
2025-08-22 17:38 ` [PATCH v4 3/3] net: phy: mxl-86110: add basic support for MxL86111 PHY Daniel Golle
2025-08-22 19:45 ` [PATCH v4 1/3] net: phy: mxl-86110: add basic support for led_brightness_set op Andrew Lunn
2025-08-26 0:10 ` Jakub Kicinski [this message]
2025-08-26 0:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250825171051.1fd1806d@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®