From: Jason Andryuk <jason.andryuk@amd.com>
To: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
Cc: Jason Andryuk <jason.andryuk@amd.com>,
<xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/3] xen/events: Cleanup find_virq() return codes
Date: Mon, 25 Aug 2025 20:55:13 -0400 [thread overview]
Message-ID: <20250826005517.41547-2-jason.andryuk@amd.com> (raw)
In-Reply-To: <20250826005517.41547-1-jason.andryuk@amd.com>
rc is overwritten by the evtchn_status hypercall in each iteration, so
the return value will be whatever the last iteration is. Change to an
explicit -ENOENT for an un-found virq and return 0 on a successful
match.
Signed-off-by: Jason Andryuk <jason.andryuk@amd.com>
---
v2:
New
---
drivers/xen/events/events_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index 41309d38f78c..199afe59f357 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -1318,7 +1318,7 @@ static int find_virq(unsigned int virq, unsigned int cpu, evtchn_port_t *evtchn)
{
struct evtchn_status status;
evtchn_port_t port;
- int rc = -ENOENT;
+ int rc;
memset(&status, 0, sizeof(status));
for (port = 0; port < xen_evtchn_max_channels(); port++) {
@@ -1331,10 +1331,10 @@ static int find_virq(unsigned int virq, unsigned int cpu, evtchn_port_t *evtchn)
continue;
if (status.u.virq == virq && status.vcpu == xen_vcpu_nr(cpu)) {
*evtchn = port;
- break;
+ return 0;
}
}
- return rc;
+ return -ENOENT;
}
/**
--
2.50.1
next prev parent reply other threads:[~2025-08-26 0:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 0:55 [PATCH v2 0/3] xen/events: Fix Global and Domain VIRQ tracking Jason Andryuk
2025-08-26 0:55 ` Jason Andryuk [this message]
2025-08-26 7:22 ` [PATCH v2 1/3] xen/events: Cleanup find_virq() return codes Jan Beulich
2025-08-26 15:03 ` Jason Andryuk
2025-08-27 15:16 ` Jürgen Groß
2025-08-26 0:55 ` [PATCH v2 2/3] xen/events: Return -EEXIST for bound VIRQs Jason Andryuk
2025-08-27 15:21 ` Jürgen Groß
2025-08-27 22:11 ` Jason Andryuk
2025-08-26 0:55 ` [PATCH v2 3/3] xen/events: Update virq_to_irq on migration Jason Andryuk
2025-08-27 15:28 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250826005517.41547-2-jason.andryuk@amd.com \
--to=jason.andryuk@amd.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_tyshchenko@epam.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®