From: kernel test robot <lkp@intel.com>
To: Sumit Gupta <sumitg@nvidia.com>,
rafael@kernel.org, viresh.kumar@linaro.org, lenb@kernel.org,
robert.moore@intel.com, corbet@lwn.net, pierre.gondois@arm.com,
zhenglifeng1@huawei.com, ray.huang@amd.com,
gautham.shenoy@amd.com, mario.limonciello@amd.com,
perry.yuan@amd.com, linux-pm@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-doc@vger.kernel.org,
acpica-devel@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-tegra@vger.kernel.org, treding@nvidia.com,
jonathanh@nvidia.com, vsethi@nvidia.com, ksitaraman@nvidia.com,
sanjayc@nvidia.com, bbasu@nvidia.com, sumitg@nvidia.com
Subject: Re: [PATCH v2 1/7] ACPI: CPPC: add perf control read API and clarify naming
Date: Tue, 26 Aug 2025 07:41:18 +0800 [thread overview]
Message-ID: <202508260711.I7imWLTG-lkp@intel.com> (raw)
In-Reply-To: <20250823200121.1320197-2-sumitg@nvidia.com>
Hi Sumit,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.17-rc3 next-20250825]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sumit-Gupta/ACPI-CPPC-add-perf-control-read-API-and-clarify-naming/20250824-040531
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20250823200121.1320197-2-sumitg%40nvidia.com
patch subject: [PATCH v2 1/7] ACPI: CPPC: add perf control read API and clarify naming
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20250826/202508260711.I7imWLTG-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250826/202508260711.I7imWLTG-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202508260711.I7imWLTG-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/cpufreq/amd-pstate.c:524:8: error: call to undeclared function 'cppc_set_perf'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
524 | ret = cppc_set_perf(cpudata->cpu, &perf_ctrls);
| ^
drivers/cpufreq/amd-pstate.c:524:8: note: did you mean 'cppc_set_epp'?
include/acpi/cppc_acpi.h:170:12: note: 'cppc_set_epp' declared here
170 | extern int cppc_set_epp(int cpu, u64 epp_val);
| ^
1 error generated.
vim +/cppc_set_perf +524 drivers/cpufreq/amd-pstate.c
e059c184da47e9 Huang Rui 2021-12-24 480
77fbea69b0ffad Mario Limonciello 2024-12-09 481 static int shmem_update_perf(struct cpufreq_policy *policy, u8 min_perf,
555bbe67a622b2 Dhananjay Ugwekar 2025-02-05 482 u8 des_perf, u8 max_perf, u8 epp, bool fast_switch)
e059c184da47e9 Huang Rui 2021-12-24 483 {
77fbea69b0ffad Mario Limonciello 2024-12-09 484 struct amd_cpudata *cpudata = policy->driver_data;
e059c184da47e9 Huang Rui 2021-12-24 485 struct cppc_perf_ctrls perf_ctrls;
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 486 u64 value, prev;
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 487 int ret;
e059c184da47e9 Huang Rui 2021-12-24 488
fff395796917ac Mario Limonciello 2024-12-09 489 if (cppc_state == AMD_PSTATE_ACTIVE) {
77fbea69b0ffad Mario Limonciello 2024-12-09 490 int ret = shmem_set_epp(policy, epp);
fff395796917ac Mario Limonciello 2024-12-09 491
fff395796917ac Mario Limonciello 2024-12-09 492 if (ret)
fff395796917ac Mario Limonciello 2024-12-09 493 return ret;
fff395796917ac Mario Limonciello 2024-12-09 494 }
fff395796917ac Mario Limonciello 2024-12-09 495
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 496 value = prev = READ_ONCE(cpudata->cppc_req_cached);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 497
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 498 value &= ~(AMD_CPPC_MAX_PERF_MASK | AMD_CPPC_MIN_PERF_MASK |
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 499 AMD_CPPC_DES_PERF_MASK | AMD_CPPC_EPP_PERF_MASK);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 500 value |= FIELD_PREP(AMD_CPPC_MAX_PERF_MASK, max_perf);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 501 value |= FIELD_PREP(AMD_CPPC_DES_PERF_MASK, des_perf);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 502 value |= FIELD_PREP(AMD_CPPC_MIN_PERF_MASK, min_perf);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 503 value |= FIELD_PREP(AMD_CPPC_EPP_PERF_MASK, epp);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 504
77fbea69b0ffad Mario Limonciello 2024-12-09 505 if (trace_amd_pstate_epp_perf_enabled()) {
77fbea69b0ffad Mario Limonciello 2024-12-09 506 union perf_cached perf = READ_ONCE(cpudata->perf);
77fbea69b0ffad Mario Limonciello 2024-12-09 507
77fbea69b0ffad Mario Limonciello 2024-12-09 508 trace_amd_pstate_epp_perf(cpudata->cpu,
77fbea69b0ffad Mario Limonciello 2024-12-09 509 perf.highest_perf,
77fbea69b0ffad Mario Limonciello 2024-12-09 510 epp,
77fbea69b0ffad Mario Limonciello 2024-12-09 511 min_perf,
77fbea69b0ffad Mario Limonciello 2024-12-09 512 max_perf,
77fbea69b0ffad Mario Limonciello 2024-12-09 513 policy->boost_enabled,
77fbea69b0ffad Mario Limonciello 2024-12-09 514 value != prev);
77fbea69b0ffad Mario Limonciello 2024-12-09 515 }
77fbea69b0ffad Mario Limonciello 2024-12-09 516
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 517 if (value == prev)
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 518 return 0;
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 519
e059c184da47e9 Huang Rui 2021-12-24 520 perf_ctrls.max_perf = max_perf;
e059c184da47e9 Huang Rui 2021-12-24 521 perf_ctrls.min_perf = min_perf;
e059c184da47e9 Huang Rui 2021-12-24 522 perf_ctrls.desired_perf = des_perf;
e059c184da47e9 Huang Rui 2021-12-24 523
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 @524 ret = cppc_set_perf(cpudata->cpu, &perf_ctrls);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 525 if (ret)
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 526 return ret;
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 527
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 528 WRITE_ONCE(cpudata->cppc_req_cached, value);
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 529
9f5daa2f2f6ddd Mario Limonciello 2024-12-09 530 return 0;
e059c184da47e9 Huang Rui 2021-12-24 531 }
e059c184da47e9 Huang Rui 2021-12-24 532
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-08-25 23:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-23 20:01 [PATCH v2 0/7] Enhanced autonomous selection and API Sumit Gupta
2025-08-23 20:01 ` [PATCH v2 1/7] ACPI: CPPC: add perf control read API and clarify naming Sumit Gupta
2025-08-25 18:33 ` Rafael J. Wysocki
2025-09-01 13:46 ` Sumit Gupta
2025-09-01 19:00 ` Rafael J. Wysocki
2025-08-25 23:41 ` kernel test robot [this message]
2025-08-23 20:01 ` [PATCH v2 2/7] ACPI: CPPC: extend APIs to support auto_sel and epp Sumit Gupta
2025-08-23 20:01 ` [PATCH v2 3/7] ACPI: CPPC: add APIs and sysfs interface for min/max_perf Sumit Gupta
2025-08-23 20:01 ` [PATCH v2 4/7] ACPI: CPPC: add APIs and sysfs interface for perf_limited register Sumit Gupta
2025-08-23 20:01 ` [PATCH v2 5/7] cpufreq: CPPC: update policy min/max when toggling auto_select Sumit Gupta
2025-08-23 20:01 ` [PATCH v2 6/7] cpufreq: CPPC: Add sysfs for min/max_perf and perf_limited Sumit Gupta
2025-08-24 0:08 ` Randy Dunlap
2025-09-01 13:12 ` Sumit Gupta
2025-08-23 20:01 ` [PATCH v2 7/7] cpufreq: CPPC: add autonomous mode boot parameter support Sumit Gupta
2025-08-24 0:08 ` Randy Dunlap
2025-09-01 13:18 ` Sumit Gupta
2025-08-25 18:40 ` Mario Limonciello
2025-09-01 13:37 ` Sumit Gupta
2025-09-02 19:48 ` Mario Limonciello
2025-09-04 12:01 ` Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202508260711.I7imWLTG-lkp@intel.com \
--to=lkp@intel.com \
--cc=acpica-devel@lists.linux.dev \
--cc=bbasu@nvidia.com \
--cc=corbet@lwn.net \
--cc=gautham.shenoy@amd.com \
--cc=jonathanh@nvidia.com \
--cc=ksitaraman@nvidia.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mario.limonciello@amd.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=perry.yuan@amd.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=robert.moore@intel.com \
--cc=sanjayc@nvidia.com \
--cc=sumitg@nvidia.com \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=vsethi@nvidia.com \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®